Opened 11 years ago
Closed 2 weeks ago
#6380 closed defect (fixed)
MOHAWK: LB - Bad config file causes engine abort in Sheila Rae French
| Reported by: | SF/georgeqgreg | Owned by: | sluicebox |
|---|---|---|---|
| Priority: | high | Component: | Engine: Mohawk |
| Version: | Keywords: | script | |
| Cc: | Game: |
Description
Attempting to play Sheila Rae, the Brave (Windows/French) causes Scummvm to give this error in the debug console.
ERROR: Config file buggy: Junk found in line 19: '[block characters]'!
The SRAEF.LB file seems pretty messed up, the bit of text in question in the file appears as such:
Language3="English" [block characters] [Languages]
These block characters all have the hex code 7F.
It seems someone at Living Books messed up the file quite a lot, and no one ever noticed. It probably doesn't help that the original Living Books player doesn't seem to mind the garbage. Of other note, the game's title is listed in the LB file as such: BŽrengre n'a Peur de Rien
I don't know why, but I get the feeling French doesn't feature the letter Ž!
Ticket imported from: #3614698. Ticket imported from: bugs/6380.
Change History (10)
comment:1 by , 11 years ago
| Owner: | set to |
|---|
comment:2 by , 11 years ago
| Summary: | French Sheila Rae has Garbage in config file, ScummVM pukes → LB: Bad config file causes engine abort in Sheila Rae French |
|---|
comment:3 by , 11 years ago
comment:4 by , 11 years ago
tdhs: How do you know all this? Do you own a copy of the game too? If so, that's a certainly a good thing. There are rather more bugs that will require a little more work. (For other bug reports of course) Oh there are more bugs.
comment:5 by , 11 years ago
georgeqgreg: No, I don't own a copy of this game. This was bug triage based purely on the information you have provided.
comment:6 by , 11 years ago
Needs a change to the common code I think; same for the other LB config file bug which is lurking somewhere..
comment:7 by , 11 years ago
tdhs: Wow, you're good.
fuzzie: I believe you're talking about the bug in French and German versions of Just Grandma and Me I submitted awhile ago. Scummvm gets stuck on the ç in français and the ö in französisch.
comment:8 by , 4 years ago
| Summary: | LB: Bad config file causes engine abort in Sheila Rae French → MOHAWK: LB - Bad config file causes engine abort in Sheila Rae French |
|---|
comment:9 by , 2 weeks ago
| Priority: | normal → high |
|---|
Would be good to resolve this for the 2.9.0 release.
comment:10 by , 2 weeks ago
| Owner: | changed from to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Actually, it was lost and the duplicate of this bug #13920 was fixed in 5c96b20c1b2426850690f7e1683c4ad8edc18e0c and 9b59bea53baac9a3949eadc574709ad05c678a52
Hex code 0x7F is the DEL char in the ascii set: http://www.asciitable.com/
Since there are 9 of them, it looks like the intention was to delete the "English" in the previous line, but their editor instead inserted the characters rather than doing a deletion...
fuzzie: Since this is using the config-manager common class in scummvm/engines/mohawk/livingbooks.cpp to do the LB configuration file reading, can we avoid this in the engine code or does this need a change to the common code? :/