Opened 6 years ago

Closed 12 months ago

#6362 closed defect (fixed)

TONY: no 565 support

Reported by: SF/dirhyllykt Owned by: fuzzie
Priority: normal Component: Engine: Tony
Keywords: Cc:
Game: Tony Tough

Description

I've corresponded with Fuzzie, who asked me to post a reminder for this.

Tony Tough and the Night of the Roasted Moths is detected and will launch, however only the yellow hand cursor is seen. if the cursor is moved you can hear that it is moving over the existing menu options such as "New Game" because a click sound is heard, however the screen remains black.
I had read this was a known issue on Android since Android uses Mode 555 instead of 565. I also learned that Fuzzie had a patch for it. Fuzzie, your response said indeed you did have, to please remind you here so you could add it to the latest daily build.
(I've tested with the last few 1.6.x builds and the first few 1.7.x builds and this is still an issue.)
thanks!

Ticket imported from: #3614610. Ticket imported from: bugs/6362.

Attachments (1)

alternate (4.6 KB ) - added by SF/dirhyllykt 5 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by SF/dirhyllykt, 6 years ago

Summary: Android (Kindle Fire HD 8.9) Shows Cursor, but no MenuTony -Android (Kindle Fire HD 8.9) Shows Cursor, but no Menu

comment:2 by SF/dirhyllykt, 6 years ago

Owner: set to fuzzie

comment:3 by fuzzie, 6 years ago

Summary: Tony -Android (Kindle Fire HD 8.9) Shows Cursor, but no MenuTONY: no 565 support

comment:4 by fuzzie, 6 years ago

So, Tony has no 565 support and it doesn't check which mode it gets returned (so it tries drawing 555 graphics onto an 8bpp surface, without setting a palette, which means you get a black screen). Not good, this will break on various backends.

We're agreed that we should just make Tony use 565 on all machines, I think, so hopefully I can just apply the branch patch I wrote a year or so ago.

comment:5 by digitall, 5 years ago

Please see https://github.com/scummvm/scummvm/pull/438 for any future updates. When this is ready and is merged, this bug will closed as fixed.

by SF/dirhyllykt, 5 years ago

Attachment: alternate added

comment:6 by SF/dirhyllykt, 5 years ago

Yeah, I'd read all that before speaking to fuzzie back in June of 2013. Was
the patch never added to the latest builds?

(Edited by wjpalenstijn: removed duplicate quoted text)

comment:7 by digitall, 5 years ago

dirhyllykt: Firstly, please fix your e-mail client if you are going to use this to respond. You just spammed the artifact with a huge blob of a comment with a bunch of https://en.wikipedia.org/wiki/Posting_style#Top-posting junk.

Secondly, as I said "Please see https://github.com/scummvm/scummvm/pull/438 for any future updates. When this is ready and is merged, this bug will closed as fixed." If you read that thread, you see some progress to look at fixing the remaining issues still blocking merge. fuzzie will hopefully have some time to look at these in the next few weeks, but is very busy IRL until then, so please refrain from bothering her directly.

I just though that the bug required a cross link to show the current status.

comment:8 by digitall, 12 months ago

Resolution: fixed
Status: newclosed

Since https://github.com/scummvm/scummvm/pull/438 was merged to tree some time ago, closing this bug as fixed.

If there is any issue with starting Tony, then please feel free to reopen.

Note: See TracTickets for help on using tickets.