Opened 6 years ago

Closed 6 months ago

#6276 closed defect (fixed)

T7G - savegame glitches

Reported by: misterhands Owned by: digitall
Priority: normal Component: Engine: Groovie
Keywords: has-pull-request Cc:
Game: 7th Guest

Description

Latest w64 daily build
T7G DOS English

Two little savegame glitches :

1) when you use a space in the savegame name, the space character is displayed as a dot in the ScummVM Load menu.

2) when you use the ScummVM Load menu, the first savegame that appears in the list is the last one you loaded. The ones above are not shown and you need to hit the UP arrow key to make them visible. The are only 10 savegame slots in T7G, so the whole list should always be visible.

Ticket imported from: #3610960. Ticket imported from: bugs/6276.

Attachments (1)

groovie-savenames.diff (1.1 KB) - added by bluegr 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 6 years ago by lordhoto

The second issue should have been fixed with a41457e224a1cc5fcde70fa9e75d1c82abd20fc9 a few days ago.

comment:2 Changed 6 years ago by misterhands

Indeed, praise the lord :)

comment:3 Changed 6 years ago by misterhands

Hrmm I have found another one :

3) If you use SPACE in a savegame name (say in slot #1), if you go to the save menu again and move the cursor over slot #1, only the characters before the space are shown.

comment:4 Changed 4 years ago by SF/zeppin

Is this no longer an issue or is this issue platform specific?

Changed 4 years ago by bluegr

Attachment: groovie-savenames.diff added

comment:5 Changed 4 years ago by bluegr

It is still an issue. I got a patch to fix it locally, although I'll have to check some parts of it first.

I'm attaching it for reference

comment:6 Changed 8 months ago by dafioram

bluegr, I was considering reworking the same e name structure in the future to fix bugs like this and others.

Do you feel like this patch you have is a change we should try to get in?

comment:7 Changed 6 months ago by digitall

@bluegr / dafioram: I think bluegr's patch looks still relevant and should be committed. Any objections to making this into a Pull Request?

comment:8 Changed 6 months ago by digitall

Keywords: has-pull-request added

OK, since no objections, have opened this as a pull request 1377:
https://github.com/scummvm/scummvm/pull/1377

Have requested that ST review it, but it looks reasonable.

comment:9 Changed 6 months ago by digitall

As an FYI, issue 2 is fixed, but I have just replicated issue 1 and 3 here with the latest git master.

Note that the ingame save "oujia board" has no spacebar, but it accepts keyboard input and thus you can use spaces that way. These render as full stops in the GMM list hence replication of issue 1.

The other issue can only be triggered if you do a GMM save with spaces in, then when you use the ingame load "oujia board", this renders as described in issue 3 i.e. only up to the space. If you use spaces with the ingame save, then these render fine in game ... but not in GMM.

Just a general compatibility issue where the space character in GMM is space and in the groovie game scripts, it appears to be fullstop :/

comment:10 Changed 6 months ago by digitall

Owner: set to digitall
Resolution: fixed
Status: newclosed

Since PR1377 has now been merged, this can be closed as fixed.

@bluegr: Thanks for the patch.

@misterhands etc. : Feel free to test with next nightly build.

Note: See TracTickets for help on using tickets.