Opened 7 years ago

Closed 2 years ago

#6272 closed defect (fixed)

ZAK AMIGA: Audio crash

Reported by: wjp Owned by: csnover
Priority: blocker Component: Engine: SCUMM
Keywords: has-backtrace has-pull-request Cc:
Game: Zak McKracken

Description

Reported by ThomasZ on IRC

Linux/x86_64

User picked target 'zak-v2-amiga' (gameid 'zak')...
Looking for a plugin supporting this gameid... SCUMM [all games]
Starting 'Zak McKracken and the Alien Mindbenders'
Enhanced V2 game detected

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffeec9f700 (LWP 14224)]
0x0000000000000000 in ?? ()
(gdb) bt
#0 0x0000000000000000 in ?? ()
#1 0x00000000016890fc in Audio::RawStream<false, false, false>::fillBuffer (this=0x26e1920, maxSamples=1)
at ../../src-master/src/audio/decoders/raw.cpp:143
#2 0x0000000001687bda in Audio::RawStream<false, false, false>::readBuffer (this=0x26e1920,
buffer=0x2287abc, numSamples=1) at ../../src-master/src/audio/decoders/raw.cpp:108
#3 0x00000000005bcf02 in Scumm::Player_MOD::do_mix (this=0x2287a90, data=0x26961d0, len=0)
at ../../src-master/src/engines/scumm/player_mod.cpp:191
#4 0x00000000005bd1fd in Scumm::Player_MOD::readBuffer (this=0x2287a90, buffer=0x26961d0, numSamples=1410)
at ../../src-master/src/engines/scumm/player_mod.h:58
#5 0x00000000016c38e2 in Audio::CopyRateConverter<true, false>::flow (this=0x23ed310, input=...,
obuf=0x232a640, osamp=1410, vol_l=256, vol_r=256) at ../../src-master/src/audio/rate.cpp:305
#6 0x000000000167aab1 in Audio::Channel::mix (this=0x23f4570, data=0x232a640, len=705)
at ../../src-master/src/audio/mixer.cpp:610
#7 0x0000000001679379 in Audio::MixerImpl::mixCallback (this=0x22f5890, samples=0x232a640 "", len=705)
at ../../src-master/src/audio/mixer.cpp:291
#8 0x00000000015b7acd in SdlMixerManager::callbackHandler (this=0x22e1030, samples=0x232a640 "", len=2820)
at ../../src-master/src/backends/mixer/sdl/sdl-mixer.cpp:138
#9 0x00000000015b7b2d in SdlMixerManager::sdlCallback (this_=0x22e1030, samples=0x232a640 "", len=2820)
at ../../src-master/src/backends/mixer/sdl/sdl-mixer.cpp:145
#10 0x00007ffff7b4e1a1 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#11 0x00007ffff7b56406 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#12 0x00007ffff7b99899 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#13 0x00007ffff4940b50 in start_thread (arg=<optimized out>) at pthread_create.c:304
#14 0x00007ffff607ca7d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#15 0x0000000000000000 in ?? ()

Ticket imported from: #3610255. Ticket imported from: bugs/6272.

Change History (8)

comment:1 by wjp, 7 years ago

Component: Engine: SCUMM
Game: Zak McKracken

comment:2 by bluegr, 7 years ago

Zak Amiga works fine for me... I've tried it with Adlib, GM and Amiga Audio emulator sound settings

comment:3 by csnover, 2 years ago

Priority: normalblocker

Raising all identified crasher, hang, and memory violation bugs which I could not fully triage myself to blocker priority for the next release.

comment:4 by csnover, 2 years ago

Keywords: has-backtrace added

comment:5 by csnover, 2 years ago

Owner: set to csnover
Resolution: worksforme
Status: newclosed

I am not able to reproduce any audio crash after manually playing back all sounds. With no way to get additional information from the OP I am closing this ticket.

comment:6 by csnover, 2 years ago

Resolution: worksforme
Status: closednew

Ach, whoops. I managed to fail to turn on ASan. Now I see a use-after-free when stopping playback.

comment:7 by csnover, 2 years ago

Keywords: has-pull-request added
Resolution: fixed
Status: newpending

comment:8 by csnover, 2 years ago

Status: pendingclosed

Thanks for your report! A patch for this issue has been added in commit 0eda63bed1b2d7fe0dba1360cad880b826248eaa and will be available in daily builds 1.10.0git-5370 and later.

Note: See TracTickets for help on using tickets.