Opened 8 years ago

Closed 8 years ago

#6039 closed defect (fixed)

DREAMWEB: graphical glitch on UKV CD version loading screen

Reported by: SF/banjo-oz Owned by: bluegr
Priority: normal Component: Engine: Dreamweb
Keywords: Cc:
Game: Dreamweb

Description

ScummVM: 1.5.0git2963-ge23ac65
Language: English
Game version: CD ("talkie") UKV original 1994 release

Once detected (as "dreamweb-cd") this version has a graphical bug in the save/load screen. It only happens with this specific detected version (that is, not with the floppy or CD re-releases) and only in ScummVM (that is, not under DOSBox).

See attached screenshots for this "red dot" glitch (and lack of in DOSbox). There may be other graphics glitches caused, but this is the one I spotted immediately.

No idea why it only happens with this release (I've tried re-copying the original CD files to make sure it wasn't a file problem) or what causes it.

Ticket imported from: #3528160. Ticket imported from: bugs/6039.

Attachments (2)

dreamweb_loadscreen_ukv_scummvm_reddotglitch.png (86.8 KB ) - added by SF/banjo-oz 8 years ago.
Dreamweb 'red dot glitch' in UKV version under ScummVM
dreamweb_loadscreen_ukv_dosbox_reddotglitch.png (99.6 KB ) - added by SF/banjo-oz 8 years ago.
Dreamweb 'red dot glitch' in UKV version not present under DOSBox.

Download all attachments as: .zip

Change History (12)

by SF/banjo-oz, 8 years ago

Dreamweb 'red dot glitch' in UKV version under ScummVM

by SF/banjo-oz, 8 years ago

Dreamweb 'red dot glitch' in UKV version not present under DOSBox.

comment:1 by SF/banjo-oz, 8 years ago

Component: Engine: Dreamweb
Game: Dreamweb

comment:2 by digitall, 8 years ago

This dialog is the one which appears at startup of Dreamweb, if savegames already exist i.e. it allows the user to choose between loading, new game or exit.
This is done by the "DoDecisions" arc in the main dreamweb loop, which calls decide() etc.
Tracing down from this, the "Frame" in this is loaded via _saveGraphics from the file DREAMWEB.G08

The display of the frame is done by the small function "showOpBox()" in engines/dreamweb/saveload.cpp, which is given below:
void DreamWebEngine::showOpBox() {
showFrame(_saveGraphics, kOpsx, kOpsy, 0, 0);

// This call displays half of the ops dialog in the CD version. It's not
// in the floppy version, and if it's called, a stray red dot is shown in
// the game dialogs.
if (isCD())
showFrame(_saveGraphics, kOpsx, kOpsy + 55, 4, 0);
}

The problem here is that the early UK-V CD version is almost identical in the main datafiles to the international floppy release, apart from the SPEECH folder and changes to the main executable... i.e. it is a CD release, but the second showFrame needs to be skipped as the G08 file is as per the floppy release and will put in this red dot if the call is made. If we modify the version to report as Floppy, then the speech will fail again... so a solution for this is tricky.

banjo-oz: Please standby... We know why, but a fix is a little tricky.

comment:3 by bluegr, 8 years ago

Thanks for reporting! Odd version, indeed.

Fixed in commit b678dca. The fix should be available in the next daily version. Please test it so that the bug report can be closed.

comment:4 by bluegr, 8 years ago

Owner: set to bluegr
Resolution: fixed

comment:5 by bluegr, 8 years ago

Also, you may need to remove the game entry from the ScummVM game list and readd it

comment:6 by digitall, 8 years ago

Status: newpending

comment:7 by SF/banjo-oz, 8 years ago

Status: pendingnew

comment:8 by SF/banjo-oz, 8 years ago

Removed and re-added... and the bug is fixed: no red dot on the load/options screen. Thanks!

comment:9 by bluegr, 8 years ago

Status: newclosed

comment:10 by bluegr, 8 years ago

Great, thanks for the feedback :) Closing

Note: See TracTickets for help on using tickets.