Opened 14 years ago

Closed 5 months ago

#6013 closed defect (fixed)

TINSEL: DW1 - Act 2: Amazon dialog still skipping in GRA Versions

Reported by: misterhands Owned by: sluicebox
Priority: normal Component: Engine: Tinsel
Version: Keywords: original
Cc: Game: Discworld

Description

This was supposed to be fixed, but it isn't, at least for me. See bug ID: 2852731. scummVM 1.4.1 win32, Discworld multilang set to french, GRA files

The "lovable street starfish" coin flip animation still cuts dialog with the amazon in Act II.

Ticket imported from: #3512752. Ticket imported from: bugs/6013.

Attachments (1)

dw.023 (3.6 KB ) - added by misterhands 14 years ago.
Talk to Amazon

Download all attachments as: .zip

Change History (21)

by misterhands, 14 years ago

Attachment: dw.023 added

Talk to Amazon

comment:1 by digitall, 14 years ago

The bug referenced is #2852731 "DW1: Act 2 Amazon dialog skipping": https://sourceforge.net/tracker/?func=detail&aid=2852731&group_id=37116&atid=418820

This was fixed by dreammaster on 2009-09-13 in commit 31585ebac06014db420bf2688036b935f54a4082 which should mean this was fixed in v1.1.0

comment:2 by digitall, 14 years ago

Owner: set to dreammaster

comment:3 by digitall, 14 years ago

Ah, I see the problem. The workaround added in 31585ebac06014db420bf2688036b935f54a4082 only fixes the bug in the SCN version, not the GRA versions.

dreammaster: Any chance you can work out a fix for this? If necessary, by working out the relevant equivalent script with misterhands?

comment:4 by digitall, 14 years ago

Summary: DW1: Act 2 Amazon dialog skipping - stillDW1: Act 2 Amazon dialog still skipping in GRA Versions

comment:5 by dreammaster, 14 years ago

Thanks for the initial review. I suspected as much when I read the bug description, but it's nice to have it confirmed. I'm a bit pressed for time right now, but I may be able to have a look into it onto the weekend.

comment:6 by digitall, 14 years ago

dreammaster: No problem. Thanks in advance...

comment:7 by dreammaster, 14 years ago

I tried loading the attached savegame, and can't replicate any problem. I double click on the amazon, and I hear all the speech correctly, without any interruptions.

The only thing I did notice was that one of the conversation entries with the street starfish wouldn't play, and only shows the text, but as far as I'm aware, that's a bug in the original sound resources, and not something that can be fixed.

comment:8 by misterhands, 14 years ago

Odd... was that on the GRA multi-language version ?

comment:9 by digitall, 14 years ago

dreammaster: To confirm... GRA Multilang version? Set to French? v1.4.1? On Win32?

comment:10 by dreammaster, 14 years ago

Ah, no. Tested on the English version - it seems to explicitly suppress sounds for the coin flipping when the conversation is active. I don't actually own the international version, so I guess I'll have to release this bug for someone else with the multi-lingual version to take a crack at.

comment:11 by dreammaster, 14 years ago

Owner: dreammaster removed

comment:12 by sev-, 14 years ago

This bug is nice to get fixed before the release. Raising priority for keeping the track.

comment:13 by sev-, 14 years ago

Priority: normalhigh

comment:14 by sev-, 13 years ago

Owner: set to dreammaster

comment:15 by dreammaster, 13 years ago

Owner: dreammaster removed

comment:16 by dreammaster, 13 years ago

Seems to have been accidentally reassigned back to me at some stage. Releasing ownerhsip since, for now, I don't own the international GRA version.

comment:17 by raziel-, 6 years ago

Summary: DW1: Act 2 Amazon dialog still skipping in GRA VersionsTINSEL: DW1 - Act 2: Amazon dialog still skipping in GRA Versions

comment:18 by sev-, 6 years ago

Priority: highnormal

comment:19 by sluicebox <22204938+sluicebox@…>, 5 months ago

In 517b8d19:

TINSEL: Fix DW1 Act 2 Amazon speech in all versions

Fixes bug #6013

comment:20 by sluicebox, 5 months ago

Keywords: original added
Owner: set to sluicebox
Resolution: fixed
Status: newclosed

Fixed in 517b8d192d286aa77f18ab39eac97f968e601f8b

There was some confusion on this ticket. This bug exists in all .GRA versions, because all .GRA versions have identical .GRA files. (Excluding demos.) There wasn't anything special about the European .GRA version, this bug is easily reproducible in the English-only version too using the attached save. Only the .TXT and audio files are different between localized versions. That the attached save was able to be loaded at all in an English-only version confirms this; if the scene file was different it would have crashed.

This bug also exists in Mac English-only .SCN version, and I've fixed that too. Subsequent versions fixed this bug in the same way that dreammaster did: by removing the problematic StopSample call from the script.

Note: See TracTickets for help on using tickets.