Opened 7 years ago

Closed 7 years ago

Last modified 7 months ago

#5994 closed defect (fixed)

GUI: Highlighting scrollbar buttons glitches with 1x scaler

Reported by: lordhoto Owned by: digitall
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

Platform: Linux/amd64
Build from commit: c3b52343dceaae253df9324a417a526f13c52333

This only seems to affect scummmodern. When trying to highlight the scrollbar buttons in the launcher for example the button's background does not get red and furthermore the triangle shape changes a little bit.

Ticket imported from: #3493324. Ticket imported from: bugs/5994.

Change History (7)

comment:1 Changed 7 years ago by eriktorbjorn

I could be wrong, but to me it looks like scrollbar_button_hover (in gui/themes/scummmodern/scummmodern_gfx.stx) for low resolutions is set up to not fill the rounded square that makes up the scrollbar button. I don't know why. If the gradient doesn't look good at such small sizes, perhaps a solid colour would be preferable?

I have no idea about the triangle thing.

comment:2 Changed 7 years ago by lordhoto

Yeah wjp pointed that out to me on IRC yesterday too. I still think it's confusing to say the least. IMHO we should have it be highlighted properly too.

comment:3 Changed 7 years ago by digitall

We now have a fix for this bug filed in https://github.com/scummvm/scummvm/pull/219 to be reviewed.

comment:4 Changed 7 years ago by digitall

Have tested with and without the fix and this does correct both issues reported here.

comment:5 Changed 7 years ago by digitall

Owner: set to digitall
Resolution: fixed
Status: newclosed

comment:6 Changed 7 years ago by digitall

Merged pull request to fix in commit 0a08b2461fe5ff55ef83253d42d05138711fba22... Closing.

comment:7 Changed 7 months ago by digitall

Component: GUI
Note: See TracTickets for help on using tickets.