Opened 8 years ago

Closed 8 years ago

#5983 closed defect (fixed)

SCI: LONGBOW: Wrong shade of grey for cursors

Reported by: SF/kurufinwe Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: Conquests of the Longbow

Description

Using ScummVM 1.5.0git2420-g975801b on Win 7 64 bit. Playing Conquests of the Longbow (DOS, English, v 1.0 with official Sierra patch).

The cursors in Longbow mostly use black and white, but some of them (bow, look and especially talk) have some grey pixels. As shown in the attached file, the shade of grey used by ScummVM is much too dark (left is the original interpreter in DOSBox, right is ScummVM).

Ticket imported from: #3489101. Ticket imported from: bugs/5983.

Attachments (1)

cursors.png (12.7 KB ) - added by SF/kurufinwe 8 years ago.
Left is original, right is ScummVM

Download all attachments as: .zip

Change History (4)

by SF/kurufinwe, 8 years ago

Attachment: cursors.png added

Left is original, right is ScummVM

comment:1 by bluegr, 8 years ago

This is due to the grey color used in the cursor palette.

Adding the following hack in GfxCursor::kernelSetShape() after setting colorMapping[3] (similar to the LB1 one) makes the colors match, but it's not the right way to address this issue:
if (g_sci->getGameId() == GID_LONGBOW)
colorMapping[3] = _palette->matchColor(223, 223, 223); // Light Grey

We need to determine if this color is hardcoded in the interpreter or set from the scripts themselves

comment:2 by bluegr, 8 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:3 by bluegr, 8 years ago

Added the aforementioned hack in 24e57808aa946ad38379b43ca205af6ef151c66a, which fixes the issue.

Closing

Note: See TracTickets for help on using tickets.