Opened 8 years ago

Closed 7 years ago

Last modified 13 months ago

#5955 closed defect (wontfix)

GUI: Missing transparency in Options with builtin theme

Reported by: lordhoto Owned by: sev-
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

Starting from 1.2.0 on it seems the transparency of the "Options" dialog background was broken(/maybe removed by purpose?). 1.1.1 definitly had support for this, I checked it with some old Win32 build. I also attached a screenshot from 1.0.0 where you can see that it is possible to see the game list entries through the background of the "Options" dialog. This also affects at least the "Edit Game..." dialog.

Ticket imported from: #3482452. Ticket imported from: bugs/5955.

Attachments (1)

scummvm-1-0-0-working.png (7.0 KB ) - added by lordhoto 8 years ago.

Download all attachments as: .zip

Change History (9)

by lordhoto, 8 years ago

Attachment: scummvm-1-0-0-working.png added

comment:1 by lordhoto, 8 years ago

There seems to be a problem with the first upload of the PNG file (the one further down in the list over here). I uploaded it again and this time it seems to work... I can not delete the old file though...

comment:2 by digitall, 8 years ago

Removed duplicate file attachment.

comment:3 by digitall, 8 years ago

Have been able to replicate the same issue on Linux x86_32. It only affects the upper half of the Options Dialog below the Tab thumbs...

Using bisection, I have located the commit which caused this:
commit ef36b80dfa120edb4648b3f1f7409fc858ba4712
Author: Eugene Sandulenko <sev@scummvm.org>
Date: Tue Jun 15 10:50:28 2010 +0000

GUI: Implement FR #2821514.

FR #2821514: "GUI: OK and Cancel buttons in option tabs".
Now tabs are visually separated from the buttons.

svn-id: r49770

comment:4 by sev-, 7 years ago

Owner: set to sev-
Resolution: wontfix
Status: newclosed

comment:5 by sev-, 7 years ago

It seems that wrong file was removed.

Anyway, it was not intended to see the underlying dialog, so I am not keen of restoring that (mis)feature.

comment:6 by digitall, 7 years ago

No, it was not. Downloaded the attached PNG file and it is fine for me.

SF.net does have a fault where about 10% of the time, I get a file containing a bunch of html/js instead of the real contents... so I now check with a hexeditor or similar after download to be sure the attachment download is good.
I suspect their CDN has some kind of flakiness... as retrying a few times, I eventually get the "good" version.

For reference, the good downloaded attachment has the following:
ce853cbc8910f22f53aee3e7c2eae0bf *scummvm-1-0-0-working.png

comment:7 by digitall, 7 years ago

As for whether the dialog _should_ have transparency, I have no view on that and it is a point to decide for the GUI team.

comment:8 by digitall, 13 months ago

Component: GUI
Note: See TracTickets for help on using tickets.