Opened 12 years ago

Closed 12 years ago

#5904 closed defect (fixed)

MOHAWK: Hebrew Tortoise and Hare not detected

Reported by: SF/georgeqgreg Owned by: fuzzie
Priority: normal Component: Engine: Mohawk
Version: Keywords: detection
Cc: Game:

Description

This is the MD5 of the OUTLINE file of the rare Hebrew translation of The Tortoise and the Hare (Living Books) 23135777370cf1ff00aa7247e93642d3

Don't worry about compatibility, I've already brute-forced it to working with the OUTLINE from Just Grandma and Me v2. It works great!

Another interesting note is that the contents of the OUTLINE file indicate that the game is based on the German version. Weird... Actually, I didn't even know there was a German version!

Ticket imported from: #3441928. Ticket imported from: bugs/5904.

Attachments (1)

mohawk-th-he-fix.patch (646 bytes ) - added by digitall 12 years ago.
Patch to add detection

Download all attachments as: .zip

Change History (21)

comment:1 by fuzzie, 12 years ago

Owner: set to fuzzie

comment:2 by digitall, 12 years ago

georgegreg: Thanks for the bug report.

In order to progress this, we will need MD5sums to add the detection entry. Could you attach a text file with a file list of your datafiles along with MD5sums. The output from a tool such as http://www.md5summer.org/ would be optimal.

Also, we will need the MD5sums limited to the first 5000 bytes of each file as well.. This is slightly harder as there is no easy GUI tool to do this AFAIK (unless md5summer has a "limit to <n> bytes" option). Please see here for instructions: http://wiki.scummvm.org/index.php/Reporting_unknown_MD5_checksums

The output from a "unknown variant" detection in an unmodified ScummVM would be a start.

comment:3 by fuzzie, 12 years ago

Well, I think more useful in this case would be the stanza you're using and it already works with, and details of which platform (Windows? Mac?) it's for, if you're sure it's fine with your stanza. Release year and interpreter version would be nice too if you know them, but non-essential. :-)

(Usually these later games use functionality which isn't entirely supported yet, so I'm (happily) surprised if it's working!)

comment:4 by SF/georgeqgreg, 12 years ago

No no... you all have understood me wrong, sorry. The game simply IS NOT detected in ScummVM... to get it to work, I had to merge it with the datafiles with Grandma V2 so it would be detected at all!

So no ScummVM MD5s or anything that, ScummVM gives no MD5s as it detects no game... I shall try one of the alternatives that tdhs mentions, thank you...

Platform: (Both game and ScummVM) Windows Release year: Unknown, datafiles have a 1995 timestamp... Interpreter version: Whichever Grandma V2 runs on, I guess...

comment:5 by digitall, 12 years ago

Summary: Hebrew Tortoise and Hare OUTLINE MD5MOHAWK: Hebrew Tortoise and Hare not detected

comment:6 by digitall, 12 years ago

georgeqgreg: Starting again, since this seems to be confusing.

Please provide md5sums for your unmodified datafiles as per: http://wiki.scummvm.org/index.php/Reporting_unknown_MD5_checksums and attach them to this bug as a comment or text file.

These are required for us to add a specific detection entry for your variant.

comment:7 by SF/georgeqgreg, 12 years ago

tdhs: Carried out the instructions. Somehow, I doubt you'll find the output satisfactory, though.

md5deep: WARNING: You are running a 32-bit program on a 64-bit system. md5deep: You probably want to use the 64-bit version of this program.

comment:8 by digitall, 12 years ago

georgeqgreg: Sorry about this. There was a minor error in the Win32 md5deep usage instructions on the wiki page.

This has now been corrected. The warning should still occur, but this should not be a problem and there should now be more useful output as well :-)

comment:9 by digitall, 12 years ago

FYI, the problem was the command, which has now been corrected:

md5deep -p size file | find /i "offset 0-"

comment:10 by SF/georgeqgreg, 12 years ago

Thanks. Working great now. MD5 of TORTB.LB is 9a7932c32bf1d6faf27fae8801ba967a

For reference, the layout's nearly the same as the European version, (it was based on that release) just it's missing the FP, FR, FP, DC, DP and DR folders. (Those were for French and German, originally.) What's left over is the BC, BP and BR folders, which were for UK English, though they're Hebrew here.

comment:11 by digitall, 12 years ago

Attaching patch to add detection for this variant. Will commit tomorrow (Github services are in outage...)

by digitall, 12 years ago

Attachment: mohawk-th-he-fix.patch added

Patch to add detection

comment:12 by digitall, 12 years ago

(Github services restored)

Commited detection entry to Git master in 910e93db40c3c9fa4032324bf14bc1fb22c074f2

georgeqgreg: Please test with the next daily build: http://www.scummvm.org/downloads/#daily

and confirm here if detection is successful, that the game starts and runs correctly.

comment:13 by SF/georgeqgreg, 12 years ago

*breaths deep*

Well, I have good news and bad news. The good news is that the game worked fine in my limited playtime. Only glitch I saw is that strange one where there's two tortoises on the menu page, though that also happens on the main page. Bad news: I forgot I had modified the file to access hidden content in the game. Unfortunately, I changed it enough to change the MD5 drastically. As a result, my MD5 is invalid. The correct one should be 23135777370cf1ff00aa7247e93642d3. *continues facepalming*

comment:14 by digitall, 12 years ago

*raise eyebrow*... Corrected md5sum in commit 8c5f988a005f8bdf11ad9ea025bc31a010bd133e

Please retest with next nightly build...

comment:15 by digitall, 12 years ago

Status: newpending

comment:16 by digitall, 12 years ago

As the user has failed to respond, assuming that this is working fine. Setting bug to pending. Unless the user responds, this will be automatically closed within 14 days.

comment:17 by SF/georgeqgreg, 12 years ago

Status: pendingnew

comment:18 by SF/georgeqgreg, 12 years ago

Sorry about the lack of a response. I've been a little busy with current endeavours. The game seems to work perfectly, well, as good as on the original EXE, anyway. Have tested it on Windows with the current SVN build. Probably will test it more extensively, and with other builds in the future. Thank you for your time.

comment:19 by digitall, 12 years ago

georgeqgreg: No problem. Thank you for confirming this. Btw, we are using Git, not SVN now... but a daily build is the same either way. Closing...

comment:20 by digitall, 12 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.