Opened 8 years ago

Closed 7 years ago

Last modified 4 years ago

#5865 closed defect (fixed)

SCI: PQ1SCI: Stuck in briefing room

Reported by: tsoliman Owned by: m-kiewitz
Priority: low Component: Engine: SCI
Keywords: original script Cc:
Game: Police Quest 1

Description

When the briefing is about to start, pathfinding seems to get in the way and Sonny doesn't find his seat after being told to sit down (clashes with one of the people entering the room, the other guy resolves and sonny stops or the other way round)
Control is disabled at this point so there's no way to manually sit down.
I was able to get around this by loading and retrying and it works as it only happens half the time
Self compiled linux git master e5889af

Ticket imported from: #3420669. Ticket imported from: bugs/5865.

Attachments (2)

pq1sci.004 (29.2 KB ) - added by tsoliman 8 years ago.
SAVEGAME: Wait and you will be told to sit down and won't be able to
PQ1SG.004 (18.2 KB ) - added by tsoliman 8 years ago.
SAVEGAME: same thing in dosbox

Download all attachments as: .zip

Change History (17)

by tsoliman, 8 years ago

Attachment: pq1sci.004 added

SAVEGAME: Wait and you will be told to sit down and won't be able to

comment:1 by tsoliman, 8 years ago

Summary: SCI: PQ1: Stuck in briefing roomSCI: PQ1SCI: Stuck in briefing room

comment:2 by digitall, 8 years ago

I can confirm replication of this with the attached savegame and latest Git master.
It doesn't seem to be linked to whether you load from launcher or in game.

comment:3 by digitall, 8 years ago

With ./scummvm -d 5 --debugflags=Pathfinding, the following information is given:
kRestoreGame(,4)
Savegame in file pq1sci.004 ok, id 4
[avoidpath] Pathfinding input:
Start point: (193, 146)
End point: (135, 134)
Optimization level: 1
Polygons:
3: (72, 122) (190, 152) (202, 152) (255, 98) (146, 81) (67, 116) (72, 122);
2: (158, 100) (176, 89) (212, 95) (195, 109) (158, 100);
2: (100, 123) (136, 100) (219, 119) (191, 147) (144, 134) (145, 126) (134, 132) (100, 123);

Returning path:
(193, 146) (191, 147) (135, 134);

With the bug not occuring...

comment:4 by digitall, 8 years ago

Do difference in this output in the bug occuring case...

comment:5 by tsoliman, 8 years ago

> No difference in this output in the bug occuring case...

Indeed. I tried it both ways. I suspect it might be related to clicking to make the popup "go to your desk" go away.

comment:6 by digitall, 8 years ago

Ah, worked it out. The bug here is that you don't have control to manually sit down after the dialog appears indicating that you should sit down.

If you continue standing, Sgt Dooley enters and orders you to sit down three times before you get thrown off the force i.e. game over, so mouse control to "Use" the lefthand chair _SHOULD_ be possible in this scene.

Prior to the dialog appearing, you can use the mouse to walk Sonny around and use the left chair to have him sit down. The pathfinding lockup only occurs if you don't move Sonny from the initial position he occupies in the room where he fouls with the NPC paths. If you move him, the bug does not occur... and he will automatically sit down after the dialog succesfully.

It will take a SCI dev to look through the script disasm for this scene and see if this is a minor script issue with incorrectly disabling control after the dialog?

tsoliman: It would help if you could run your copy of PQ1 in DOSBox and attach a savegame from there at the same point for behaviour comparison. Thanks.

by tsoliman, 8 years ago

Attachment: PQ1SG.004 added

SAVEGAME: same thing in dosbox

comment:7 by tsoliman, 8 years ago

I was able to reproduce this bug in dosbox. Dosbox savegame attached.

comment:8 by tsoliman, 8 years ago

Keywords: script added

comment:9 by digitall, 8 years ago

Ah, so this is a script bug that occurs in the original. I will reduce the priority to indicate that this should be fixed if possible, but is not as critical.

comment:10 by digitall, 8 years ago

Keywords: original added; script removed
Priority: normallow

comment:11 by bluegr, 7 years ago

Added to the known bugs list:
http://wiki.scummvm.org/index.php/SCI/Bugs#Police_Quest_1

Closing

comment:12 by bluegr, 7 years ago

Owner: set to bluegr
Status: newclosed

comment:13 by m-kiewitz, 5 years ago

I just tried to trigger this bug and it doesn't happen - at least for me - using latest build.

comment:14 by m-kiewitz, 4 years ago

Keywords: script added
Owner: changed from bluegr to m-kiewitz
Resolution: fixed

comment:15 by m-kiewitz, 4 years ago

Finally fixed by script patch in commit 4baa9963eeb9edb65c2b85c5d29f79027fd5607b

Note: See TracTickets for help on using tickets.