Opened 8 years ago

Closed 8 years ago

Last modified 7 months ago

#5839 closed defect (fixed)

ScummVM crashes when trying to add non-SCI "ressources" file

Reported by: (none) Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: detection Cc:
Game:

Description

ScummVM crashed every time I asked him to scan folders (using mass add) that contains "ressources.xxx" (xxx = 001, 002, 003,...) files that weren't from an SCI game. So far I get two error messages depending on the files it scans:

1) "Failed to open volume file - if you got resource.p01/resource.p02/etc. files, merge them together into resource.000"
2) "Failed to open resource map file!"

Ticket imported from: #3404466. Ticket imported from: bugs/5839.

Change History (6)

comment:1 Changed 8 years ago by digitall

After a quick check, these messages come from the functions checkVolVersion() and checkMapVersion() in the SCI engine resource class (engines/sci/resource.cpp). They are only called from the same class by the method:
void ResourceManager::init(bool initFromFallbackDetector)

So the culprit here is that the SCI fallback detector is not "mass add" safe...

comment:2 Changed 8 years ago by digitall

LunaVorax: Can you give a list of the non-SCI games which contains "resources.xxx" which cause an issue here?

comment:3 Changed 8 years ago by (none)

So far, it happenned when scanning the files of a DOS shareware game called "RasterMind".
http://bit.ly/nkwxUc

comment:4 Changed 8 years ago by bluegr

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:5 Changed 8 years ago by bluegr

Fixed in rd8aaf40

comment:6 Changed 7 months ago by digitall

Component: Engine: SCI
Note: See TracTickets for help on using tickets.