Opened 8 years ago

Closed 8 years ago

#5819 closed defect (fixed)

TINSEL: DW: Crash when deleting savegame from launcher

Reported by: tsoliman Owned by: bluegr
Priority: normal Component: Engine: Tinsel
Keywords: Cc:
Game: Discworld

Description

Steps to reproduce: From the launcher select load game and then choose any savegame and hit the delete button and say yes to the confirmation dialog.

Linux self compiled git master 622f8a1

gdb backtrace:
#0 0x08b1a6ae in Tinsel::TinselEngine::getVersion (this=0x0) at ../engines/tinsel/detection.cpp:63
#1 0x08b1c9cd in Tinsel::syncSaveGameHeader (s=..., hdr=...) at ../engines/tinsel/saveload.cpp:158
#2 0x08b1d81b in Tinsel::getList (saveFileMan=0x9577aa0, target=...) at ../engines/tinsel/saveload.cpp:344
#3 0x08b1b0ff in TinselMetaEngine::removeSaveState (this=0x9577960, target=0x97655fc "dw", slot=1) at ../engines/tinsel/detection.cpp:325
#4 0x08cad326 in GUI::SaveLoadChooser::handleCommand (this=0x9765580, sender=0x9765c48, cmd=1145392160, data=0) at ../gui/saveload.cpp:157
#5 0x08ae269d in GUI::CommandSender::sendCommand (this=0x9765c48, cmd=1145392160, data=0) at ../gui/object.h:53
#6 0x08cc5cdf in GUI::ButtonWidget::handleMouseUp (this=0x9765bd8, x=32, y=5, button=1, clickCount=1) at ../gui/widget.cpp:294
#7 0x08c95a2e in GUI::Dialog::handleMouseUp (this=0x9765580, x=280, y=435, button=1, clickCount=1) at ../gui/dialog.cpp:196
#8 0x08c96f85 in GUI::GuiManager::runLoop (this=0x96ebda0) at ../gui/gui-manager.cpp:356
#9 0x08c95591 in GUI::Dialog::runModal (this=0x9765580) at ../gui/dialog.cpp:71
#10 0x08cacf52 in GUI::SaveLoadChooser::runModalWithPluginAndTarget (this=0x9765580, plugin=0x9577990, target=...) at ../gui/saveload.cpp:99
#11 0x08c9d82b in GUI::LauncherDialog::loadGame (this=0xbfffe568, item=13) at ../gui/launcher.cpp:928
#12 0x08c9dc00 in GUI::LauncherDialog::handleCommand (this=0xbfffe568, sender=0x9762188, cmd=1280262468, data=0) at ../gui/launcher.cpp:977
#13 0x08ae269d in GUI::CommandSender::sendCommand (this=0x9762188, cmd=1280262468, data=0) at ../gui/object.h:53
#14 0x08cc5cdf in GUI::ButtonWidget::handleMouseUp (this=0x9762118, x=12, y=13, button=1, clickCount=1) at ../gui/widget.cpp:294
#15 0x08c95a2e in GUI::Dialog::handleMouseUp (this=0xbfffe568, x=521, y=154, button=1, clickCount=1) at ../gui/dialog.cpp:196
#16 0x08c96f85 in GUI::GuiManager::runLoop (this=0x96ebda0) at ../gui/gui-manager.cpp:356
#17 0x08c95591 in GUI::Dialog::runModal (this=0xbfffe568) at ../gui/dialog.cpp:71
#18 0x0804f875 in launcherDialog () at ../base/main.cpp:83
#19 0x08050f30 in scummvm_main (argc=1, argv=0xbfffee04) at ../base/main.cpp:406
#20 0x0804f25f in main (argc=1, argv=0xbfffee04) at ../backends/platform/sdl/posix/posix-main.cpp:45

Ticket imported from: #3387551. Ticket imported from: bugs/5819.

Change History (3)

comment:1 by tsoliman, 8 years ago

I tried deleting from inside the game and it is kinda wonky there too. It doesn't crash but I am not able to delete the save in slot 3. I think it might be trying to delete the save in another slot instead. To reproduce that, make it so that there are no saves except 1 in slot #3 and then try to delete it from the CTRL-F5 while the game is running

comment:2 by bluegr, 8 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:3 by bluegr, 8 years ago

Fixed in commit 2c9fdf0df754176a375d5079c7e8578c6701630a

Note: See TracTickets for help on using tickets.