Opened 9 years ago

Closed 8 years ago

#5548 closed defect (fixed)

NIPPON: crash when click on top screen

Reported by: SF/windlepoons Owned by: peres
Priority: normal Component: Engine: Parallaction
Keywords: Cc:
Game: Nippon Safes

Description

When click on top screen in the game, ScummVM crashed with Segmentation fault.

In screenshot i marked this region with green line.

Nippon Safes Inc. (Multi-lingual/DOS)
ScummVM 1.2.0 (Oct 17 2010 20:52:11)

Ticket imported from: #3134445. Ticket imported from: bugs/5548.

Attachments (1)

nippon_crash_on_line.png (4.7 KB ) - added by SF/windlepoons 9 years ago.

Download all attachments as: .zip

Change History (5)

by SF/windlepoons, 9 years ago

Attachment: nippon_crash_on_line.png added

comment:1 by fuzzie, 9 years ago

http://fuzzie.org/nfs/scummvm/ns_walk.txt fixes the crash, confirmed by WindlePoons on IRC.

http://fuzzie.org/nfs/scummvm/ns_walk_2.txt adds the checks earlier in the function and improves the ones in clipMove too.

I don't know which of these are actually necessary, not sure what's really going on, but hopefully peres will find time to take a look.

comment:2 by digitall, 9 years ago

Owner: set to peres

comment:3 by digitall, 8 years ago

This no longer occurs with the latest v1.4.0pre Git master.
I think my safety corrections to pathfinding PathBuffer has fixed this i.e. 0f07082a78355b8607bf04dd4e1ba42e14fc636f and 5a0680af52499629a1b001eeb7290f27926d6ff8
This is supported as clicking in the same region outside the Monastery causes a warning to be emitted about out of bounds access to Pathbuffer.
Closing as fixed...

comment:4 by digitall, 8 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.