Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#5496 closed defect (fixed)

PQ2 Intro too fast

Reported by: SF/muyfa666 Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: script Cc:
Game: Police Quest 2

Description

Running PQ2 V1.002.011 on the latest SVN build and the intro is very much too fast. It was also too fast on the latest stable release.

Ticket imported from: #3102071. Ticket imported from: bugs/5496.

Attachments (5)

script-200-diff.txt (1.5 KB) - added by digitall 9 years ago.
Differences between original and patched SCRIPT.200
dissect-original.txt (82.5 KB) - added by digitall 9 years ago.
dissect_script output - original
dissect-patched.txt (82.6 KB) - added by digitall 9 years ago.
dissect_script output - patched
disasm-original.txt (2.0 KB) - added by digitall 9 years ago.
diasm output - original
diasm-patched.txt (843 bytes) - added by digitall 9 years ago.
disasm output - patched

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by bluegr

Seems to be a problem with this version. NewRisingSun has a patch for that specific issue:
http://www.oocities.com/belzorash/

We'll check it out and see if we can merge it or something similar to ScummVM

comment:2 Changed 9 years ago by SF/muyfa666

I get a error message about fanmade script every time I launch the game with the patch, but it is indeed working fine.

comment:3 Changed 9 years ago by digitall

The Police Quest Collection's PQ2 exhibits this issue.
The NRS patch contains a patch for SCRIPT.200.
I have dumped the original with "diskdump" and compared with a hexeditor.

Attaching difference file between the original SCRIPT.200 and patched.

Changed 9 years ago by digitall

Attachment: script-200-diff.txt added

Differences between original and patched SCRIPT.200

comment:4 Changed 9 years ago by SF/muyfa666

Ok... what does that mean in english? Do you need me to do something?

comment:5 Changed 9 years ago by digitall

muyfa666 : Not at this time... That information is intended to aid the SCI developers construct an internal patch.

comment:6 Changed 9 years ago by digitall

thebluegr:
Attaching dissect_script and disasm outputs from original and corrected script 200 Introduction::Init.

Changed 9 years ago by digitall

Attachment: dissect-original.txt added

dissect_script output - original

Changed 9 years ago by digitall

Attachment: dissect-patched.txt added

dissect_script output - patched

Changed 9 years ago by digitall

Attachment: disasm-original.txt added

diasm output - original

Changed 9 years ago by digitall

Attachment: diasm-patched.txt added

disasm output - patched

comment:7 Changed 9 years ago by bluegr

Fixed in rev 54298, based on the patch by NewRisingSun / Belzorash

comment:8 Changed 9 years ago by bluegr

Owner: set to bluegr
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.