Opened 9 years ago

Closed 9 years ago

#5477 closed defect (fixed)

FT: Truck and Aircraft computer text missing (regression)

Reported by: SF/lionsphil Owned by: Kirben
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Full Throttle

Description

During the finale, some of the interface text for the aircraft and truck computers does not appear. In particular, the truck's flashing "reported as stolen" text is missing, and any of the incorrect options result in a blank (computer) screen rather than error text (for example, most of the aircraft options should report that the system you tried to use is too damaged).

Attaching a ScummVM savegame for this point of the game. Will attach original DOS save for comparison. Click the console in the middle and any of the options other than raising the landing gear. Getting to the truck screen is easy from here: Take Off, Post-Take Off, Gear, Raise, then click on the truck cabin and screen after the cutscene. There try, for example, Defense Menu, Machine Guns, About, which will give the impression of the game locking up as it pauses for several screens of invisible text.

ScummVM 1.2.053093 (Oct 9 2010 11:56:44) running on Win32
Game version "Version B/English" (CD talkie, White Label budget release)

Note that there are previous (fixed) bugs with this text instead overprinting: e.g. 899323.

Ticket imported from: #3093750. Ticket imported from: bugs/5477.

Attachments (2)

ft.s33 (19.5 KB ) - added by SF/lionsphil 9 years ago.
ScummVM savegame for aircraft cockpit
SAVEGAME.033 (73.5 KB ) - added by SF/lionsphil 9 years ago.
Original DOS interpreter savegame for aircraft cockpit

Download all attachments as: .zip

Change History (11)

by SF/lionsphil, 9 years ago

Attachment: ft.s33 added

ScummVM savegame for aircraft cockpit

by SF/lionsphil, 9 years ago

Attachment: SAVEGAME.033 added

Original DOS interpreter savegame for aircraft cockpit

comment:1 by SF/lionsphil, 9 years ago

Also affects SVN revision 53733, built with MSVC10.

comment:2 by jvprat, 9 years ago

Summary: Truck and Aircraft computer text missingFT: Truck and Aircraft computer text missing

comment:3 by digitall, 9 years ago

Have tested with previous versions. This has been broken for quite a while.

The bug was introduced between 0.8.2 and 0.9.0.

Will bisect for exact point of breakage.

comment:4 by digitall, 9 years ago

Note : Can't load the attached ScummVM savegame with any version earlier than v1.2.0
To replicate, use boot param 930 i.e.
./scummvm -b 930 ft
Then walk to cockpit ladder twice and then use computer...

comment:5 by digitall, 9 years ago

This regression was introduced by :
r19398 | cyx | 2005-11-02 21:47:44 +0000 (Wed, 02 Nov 2005) | 2 lines

To match the original v7/v8 interpreters, use BlastTexts to display the subtitles. This allows to fix the bug #1092993. As this is quite an important change, regressions may appear. You've been warned :)

comment:6 by eriktorbjorn, 9 years ago

I can reproduce the bug, but it appears to work correctly if I have subtitles enabled - which I almost always do - so hopefully it will be fairly easy to fix.

comment:7 by eriktorbjorn, 9 years ago

It could be as simple as making a small change in ScummEngine_v7::processSubtitleQueue(). Right now, it first checks if subtitles are turned off (or if VAR(VAR_VOICE_MODE) is zero), then it checks (again) if subtitles are turned off and there is a speech version of the message.

That first test seems a bit aggressive, but I'm not confident enough about it to make any changes.

comment:8 by Kirben, 9 years ago

Owner: set to Kirben
Resolution: fixed
Status: newclosed
Summary: FT: Truck and Aircraft computer text missingFT: Truck and Aircraft computer text missing (regression)

comment:9 by Kirben, 9 years ago

I checked the disassembly of FT/DIG/COMI, and the first check doesn't make any sense at all.

Fixed, by merging the two checks together, to closer match original games.

Note: See TracTickets for help on using tickets.