Opened 9 years ago

Closed 8 years ago

#5475 closed defect (fixed)

T7G: App Crashes Attempting To Save

Reported by: SF/woram Owned by: spookypeanut
Priority: blocker Component: Engine: Groovie
Keywords: Cc:
Game: 7th Guest

Description

Running 7th Guest on ScummVM 1.2 for Mac. Numerous times I attempted to save in-game using the directory ~/Documents/ScummVM Savegames, and each time ScummVM crashed unexpectedly. (See attached crash log.) I then went to SVM's options for 7th Guest and tried to choose the above directory again as my savegame path (in case, y'know, something changed in how savegames work...it had been a long time since I touched SVM before now). SVM wouldn't let me, insisting the directory couldn't be written to. Seemed dubious, because I could write to it, but I won't challenge it. I then changed it to somewhere outside of my home directory, and 7th Guest saved my games fine.

TL;DR: ScummVM crashes when trying to save to a directory it can't write to.

Ticket imported from: #3093310. Ticket imported from: bugs/5475.

Attachments (1)

Crash Log.txt (27.8 KB ) - added by SF/woram 9 years ago.
Crash log

Download all attachments as: .zip

Change History (10)

by SF/woram, 9 years ago

Attachment: Crash Log.txt added

Crash log

comment:1 by bluegr, 9 years ago

Summary: App Crashes Attempting To SaveT7G: App Crashes Attempting To Save

comment:2 by jvprat, 9 years ago

Hello, Will. Answer some questions, please:

- Does it only happen with 7th Guest or with other games too?
- Does the new savegames directory have whitespaces too? The old one that made it crash had a whitespace: "ScummVM Savegames"
- Try copying one of the savedgames you saved on the new directory into the old "ScummVM Savegames", configure ScummVM to use that directory for savegames, load that game and try to save to another slot.

It's strange since you say you can write to that directory.

comment:3 by SF/woram, 9 years ago

Sorry, didn't notice the ticket had changed.

Most of the questions I'll have to defer for later when I get a chance to experiment, but one I can answer immediately:

'Does the new savegames directory have whitespaces too? The old one that made it crash had a whitespace: "ScummVM Savegames"'
...Yes. The full path to the new dir, which I created fresh solely because of this crash, is /Games/Emulation/ScummVM Saved Games.

comment:4 by sev-, 9 years ago

Raising priority. This is a release-critical bug.

comment:5 by sev-, 9 years ago

Priority: normalblocker

comment:6 by spookypeanut, 9 years ago

I can replicate this crash when trying to save a game to a non-writable directory, I'll have a look into fixing it.
I tried the same in scumm (MI2), and it popped up an error window, but tinsel (DW1) also crashed (with a different error message).

comment:7 by spookypeanut, 9 years ago

Owner: set to spookypeanut

comment:8 by spookypeanut, 8 years ago

Resolution: fixed
Status: newclosed

comment:9 by spookypeanut, 8 years ago

Just pushed a fix for this. If the savegame is not writable, it will now pop up a gui message and skip, instead of crashing,

Note: See TracTickets for help on using tickets.