Opened 9 years ago

Closed 7 years ago

#5465 closed defect (fixed)

FW: Looping samples don't loop in Amiga version

Reported by: SF/noncivoleva Owned by: lordhoto
Priority: normal Component: Engine: Cine
Keywords: Cc:
Game: Future Wars

Description

- ScummVM Version: any version since Future Wars support added
- Bug details: some sounds should loop indefinitely, but they don't. They are played just once. To reproduce the bug, just press the green button in the photocopier room. There will be some noise (less than a second), but in the original, the noise is persistent. I'll provide a save game. Load it and then do "aziona", "tasto verde".
- Language of game: Italian
- Platform of game: Amiga
- ScummVM platform: Windows XP 32bit

Here's a video from the original, for comparison: http://www.youtube.com/watch?v=haSciKG_jSE

Ticket imported from: #3091660. Ticket imported from: bugs/5465.

Attachments (1)

FutureWarsBUG.zip (2.4 KB ) - added by SF/noncivoleva 9 years ago.
Save game

Download all attachments as: .zip

Change History (7)

by SF/noncivoleva, 9 years ago

Attachment: FutureWarsBUG.zip added

Save game

comment:1 by SF/noncivoleva, 9 years ago

Summary: Looping samples don't loop in Amiga versionFW: Looping samples don't loop in Amiga version

comment:2 by bluegr, 8 years ago

This is a missing feature: sound repeat isn't implemented yet

For reference, check sound.cpp:
- PCSound::playSound
- PaulaSound::playSound
- PCSound::playSound

They all get a "repeat" parameter, but none of them handles it (there's a relevant TODO in PaulaSound::playSound)

comment:3 by lordhoto, 7 years ago

This should be fixed with the lasted nightly build.

The commit which fixes this is c850effc6d30cc8de9fcbdd8ac429b1d6da624e1. It would be nice if you could test this,

comment:4 by lordhoto, 7 years ago

Owner: set to lordhoto
Resolution: fixed
Status: newpending

comment:5 by bluegr, 7 years ago

This has not been closed automatically, and it's pretty old now. Closing manually.

comment:6 by bluegr, 7 years ago

Status: pendingclosed
Note: See TracTickets for help on using tickets.