Opened 9 years ago

Closed 9 years ago

Last modified 8 months ago

#5464 closed defect (invalid)

2xSaI family scalers have shifts/edges

Reported by: wjp Owned by: sev-
Priority: normal Component: Graphics: Scalers
Keywords: Cc:
Game:

Description

The 2xSaI, Super2xSaI and SuperEagle scalers seem to have slightly shifted output compared to the 2x scaler with dark edges along the bottom/right sides. See the attached screenshots.

Ticket imported from: #3091549. Ticket imported from: bugs/5464.

Attachments (4)

iceman_point2x.png (22.4 KB) - added by wjp 9 years ago.
2x scaler
iceman_2xsai.png (65.7 KB) - added by wjp 9 years ago.
2xSaI scaler
iceman_super2xsai.png (58.0 KB) - added by wjp 9 years ago.
Super2xSaI scaler
iceman_supereagle.png (89.5 KB) - added by wjp 9 years ago.
SuperEagle scaler

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by wjp

Attachment: iceman_point2x.png added

2x scaler

Changed 9 years ago by wjp

Attachment: iceman_2xsai.png added

2xSaI scaler

Changed 9 years ago by wjp

Attachment: iceman_super2xsai.png added

Super2xSaI scaler

Changed 9 years ago by wjp

Attachment: iceman_supereagle.png added

SuperEagle scaler

comment:1 Changed 9 years ago by lordhoto

I am not sure about it, but I know 2xSai for example is one of the scalers which need an additional pixel around their scaled image, maybe that is related to that somehow?

It might be useful to check the comments in backends/platform/sdl/graphics.cpp lines 874+875 and 1089-1096. Maybe we use the scaler incorrect? I.e. supply wrong coordinates or make incorrect assumptions about its output?

comment:2 Changed 9 years ago by sev-

Owner: set to sev-
Resolution: invalid
Status: newclosed

comment:3 Changed 9 years ago by sev-

That is their design. We can do nothing about it.

comment:4 Changed 8 months ago by digitall

Component: --Unset--Graphics: Scalers
Note: See TracTickets for help on using tickets.