Opened 9 years ago

Closed 9 years ago

Last modified 12 months ago

#5449 closed defect (fixed)

GRAPHICS: Code analysis warnings

Reported by: Templier Owned by: bluegr
Priority: normal Component: Graphics
Keywords: build Cc:
Game:

Description

Here are the warnings I get when compiling using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\graphics\font.cpp(232): warning C6054: String 'facename' might not be zero-terminated
d:\sources\scummvm\scummvm\graphics\font.cpp(240): warning C6054: String 'copyright' might not be zero-terminated
d:\sources\scummvm\scummvm\graphics\font.cpp(509): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'pf->bits', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\graphics\scaler.cpp(101): warning C6011: Dereferencing NULL pointer 'RGBtoYUV'
d:\sources\scummvm\scummvm\graphics\video\codecs\qdm2.cpp(1359): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'vlc->table', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\graphics\video\codecs\qdm2.cpp(3115): warning C6288: Incorrect operator: mutual inclusion over && is always zero. Did you intend to use || instead?
d:\sources\scummvm\scummvm\graphics\video\coktel_decoder.cpp(2309): warning C6011: Dereferencing NULL pointer 'out++'
d:\sources\scummvm\scummvm\graphics\video\coktel_decoder.cpp(2470): warning C6001: Using uninitialized memory 'data'
d:\sources\scummvm\scummvm\graphics\video\mpeg_player.cpp(369): warning C6011: Dereferencing NULL pointer '_rgbToPix'
d:\sources\scummvm\scummvm\graphics\video\mpeg_player.cpp(390): warning C6011: Dereferencing NULL pointer 'r_2_pix_alloc'
d:\sources\scummvm\scummvm\graphics\video\mpeg_player.cpp(362): warning C6011: Dereferencing NULL pointer '_colorTab'
d:\sources\scummvm\scummvm\graphics\video\mpeg_player.cpp(382): warning C6011: Dereferencing NULL pointer 'Cr_r_tab'

Note:
If you want to try it yourself, you will need:
- the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src)
- the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

Ticket imported from: #3087917. Ticket imported from: bugs/5449.

Change History (3)

comment:1 by bluegr, 9 years ago

font.cpp: warnings fixed, and appropriate comments added
scaler.cpp: false positive, RGBtoYUV is always initialized above
qdm2.cpp: warnings already fixed
coktel_decoder.cpp: warnings already fixed
mpeg_player.cpp: the warnings all look like false positives

comment:2 by bluegr, 9 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:3 by digitall, 12 months ago

Component: Graphics
Note: See TracTickets for help on using tickets.