SCI: Code analysis warnings
|Reported by:||Templier||Owned by:||bluegr|
Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.
d:\sources\scummvm\scummvm\engines\sci\console.cpp(2126): warning C6011: Dereferencing NULL pointer 'curValue'
d:\sources\scummvm\scummvm\engines\sci\graphics\font.cpp(91): warning C6336: Arithmetic operator has precedence over question operator, use parentheses to clarify intent
d:\sources\scummvm\scummvm\engines\sci\engine\kgraphics.cpp(354): warning C6011: Dereferencing NULL pointer 'dest'
d:\sources\scummvm\scummvm\engines\sci\engine\kpathing.cpp(1333): warning C6011: Dereferencing NULL pointer 'vertex_min'
If you want to try it yourself, you will need:
- the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src)
- the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)
Ticket imported from: #3087872. Ticket imported from: bugs/5447.