Opened 14 years ago

Closed 14 years ago

Last modified 5 years ago

#5446 closed defect (fixed)

TOON: Code analysis warnings

Reported by: Templier Owned by: bluegr
Priority: normal Component: Engine: Toon
Version: Keywords: build
Cc: Game: Toonstruck

Description

Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\engines\toon\toon.cpp(4397): warning C6011: Dereferencing NULL pointer '_animInstance'

Note: If you want to try it yourself, you will need: - the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src) - the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch ) - Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

Ticket imported from: #3087867. Ticket imported from: bugs/5446.

Change History (4)

comment:1 by bluegr, 14 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:2 by bluegr, 14 years ago

Fixed in rev #53502

comment:3 by digitall, 6 years ago

Component: Engine: Toon

comment:4 by Thunderforge, 5 years ago

Game: Toonstruck
Note: See TracTickets for help on using tickets.