#5445 closed defect (invalid)
TOUCHE: Code analysis warnings
| Reported by: | Templier | Owned by: | bluegr |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Touche |
| Version: | Keywords: | build | |
| Cc: | Game: |
Description
Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.
d:\sources\scummvm\scummvm\engines\touche\resource.cpp(477): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'spr->ptr', which is passed as an argument to 'realloc', will cause the original memory block to be leaked d:\sources\scummvm\scummvm\engines\touche\touche.cpp(2363): warning C6201: Index '40' is out of valid index range '0' to '39' for possibly stack allocated buffer '_conversationChoicesTable' d:\sources\scummvm\scummvm\engines\touche\touche.cpp(2364): warning C6201: Index '40' is out of valid index range '0' to '39' for possibly stack allocated buffer '_conversationChoicesTable'
The last two look like false positives.
Note: If you want to try it yourself, you will need: - the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src) - the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)
Ticket imported from: #3087865. Ticket imported from: bugs/5445.
Change History (3)
comment:1 by , 14 years ago
| Owner: | set to |
|---|---|
| Resolution: | → invalid |
| Status: | new → closed |
comment:2 by , 14 years ago
comment:3 by , 5 years ago
| Component: | → Engine: Touche |
|---|
All three are false positives. There is a check for realloc() for the first one, which terminates with error(). The other two are false positives, the loop they refer to is fine
Closing as invalid