#5441 closed defect (fixed)
SWORD1: Code analysis warnings
| Reported by: | Templier | Owned by: | bluegr |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sword1 |
| Version: | Keywords: | build | |
| Cc: | Game: | Broken Sword 1 |
Description
Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.
d:\sources\scummvm\scummvm\engines\sword1\resman.cpp(335): warning C6011: Dereferencing NULL pointer 'closeClu->file' d:\sources\scummvm\scummvm\engines\sword1\screen.cpp(889): warning C6336: Arithmetic operator has precedence over question operator, use parentheses to clarify intent d:\sources\scummvm\scummvm\engines\sword1\screen.cpp(890): warning C6336: Arithmetic operator has precedence over question operator, use parentheses to clarify intent
Note: If you want to try it yourself, you will need: - the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src) - the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch ) - Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)
Ticket imported from: #3087855. Ticket imported from: bugs/5441.
Change History (4)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:3 by , 5 years ago
| Component: | → Engine: Sword1 |
|---|
comment:4 by , 5 years ago
| Game: | → Broken Sword 1 |
|---|
Fixed in rev #53488, thanks for reporting this