Opened 9 years ago

Closed 9 years ago

Last modified 12 months ago

#5440 closed defect (fixed)

SAGA: Code analysis warnings

Reported by: Templier Owned by: bluegr
Priority: normal Component: Engine: SAGA
Keywords: build Cc:
Game:

Description

Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\engines\saga\saga.cpp(428): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'stringsTable.strings', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\engines\saga\saga.cpp(436): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'stringsTable.strings', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\engines\saga\shorten.cpp(369): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'lpc', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\engines\saga\shorten.cpp(433): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'unpackedBuffer', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\engines\saga\shorten.cpp(467): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'unpackedBuffer', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\engines\saga\sprite.cpp(118): warning C6308: 'realloc' might return null pointer: assigning null pointer to 'spriteList.infoList', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\engines\saga\actor.cpp(151): warning C6308: 'realloc' might return null pointer: assigning null pointer to '_tileDirections', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\engines\saga\actor.cpp(164): warning C6308: 'realloc' might return null pointer: assigning null pointer to '_walkStepsPoints', which is passed as an argument to 'realloc', will cause the original memory block to be leaked

Warning information: http://msdn.microsoft.com/en-us/library/kkedhy7c%28VS.90%29.aspx

Note:
If you want to try it yourself, you will need:
- the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src)
- the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

Ticket imported from: #3087852. Ticket imported from: bugs/5440.

Change History (3)

comment:1 by bluegr, 9 years ago

Fixed in rev #53486, thanks for reporting this

comment:2 by bluegr, 9 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:3 by digitall, 12 months ago

Component: Engine: SAGA
Note: See TracTickets for help on using tickets.