Opened 9 years ago

Closed 9 years ago

Last modified 8 months ago

#5438 closed defect (fixed)

MADE: Code analysis warnings

Reported by: Templier Owned by: bluegr
Priority: normal Component: Engine: MADE
Keywords: build Cc:
Game:

Description

Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\engines\made\screen.cpp(207): warning C6011: Dereferencing NULL pointer 'maskp'

Note:
If you want to try it yourself, you will need:
- the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src )
- the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

Ticket imported from: #3087849. Ticket imported from: bugs/5438.

Change History (3)

comment:1 Changed 9 years ago by bluegr

Fixed in rev #53487, thanks for reporting this

comment:2 Changed 9 years ago by bluegr

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:3 Changed 8 months ago by digitall

Component: Engine: MADE
Note: See TracTickets for help on using tickets.