M4: Code analysis warnings
|Reported by:||Templier||Owned by:||bluegr|
Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.
d:\sources\scummvm\scummvm\engines\m4\mads_logic.cpp(661): warning C6290: Bitwise operation on logical result: ! has higher precedence than &. Use && or (!(x & y)) instead d:\sources\scummvm\scummvm\engines\m4\console.cpp(65): warning C6031: Return value ignored: 'sscanf' d:\sources\scummvm\scummvm\engines\m4\converse.cpp(544): warning C6011: Dereferencing NULL pointer 'curEntry' d:\sources\scummvm\scummvm\engines\m4\converse.cpp(582): warning C6011: Dereferencing NULL pointer 'parentEntry' d:\sources\scummvm\scummvm\engines\m4\dialogs.cpp(301): warning C6011: Dereferencing NULL pointer 'srcP'
Note: If you want to try it yourself, you will need: - the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b ) - the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch ) - Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)
Ticket imported from: #3087845. Ticket imported from: bugs/5437.