Opened 9 years ago

Closed 9 years ago

Last modified 12 months ago

#5436 closed defect (fixed)

LURE: Code analysis warnings

Reported by: Templier Owned by: dreammaster
Priority: normal Component: Engine: Lure
Keywords: build Cc:
Game:

Description

Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\engines\lure\memory.cpp(98): warning C6308: 'realloc' might return null pointer: assigning null pointer to '_data', which is passed as an argument to 'realloc', will cause the original memory block to be leaked
d:\sources\scummvm\scummvm\engines\lure\res_struct.cpp(878): warning C6305: Potential mismatch between sizeof and countof quantities
d:\sources\scummvm\scummvm\engines\lure\room.cpp(238): warning C6011: Dereferencing NULL pointer 'entry'
d:\sources\scummvm\scummvm\engines\lure\room.cpp(601): warning C6011: Dereferencing NULL pointer '_layers[0]'

Note:
If you want to try it yourself, you will need:
- the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b )
- the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

Ticket imported from: #3087842. Ticket imported from: bugs/5436.

Change History (3)

comment:1 by dreammaster, 9 years ago

Resolution: fixed
Status: newclosed

comment:2 by dreammaster, 9 years ago

Owner: set to dreammaster

comment:3 by digitall, 12 months ago

Component: Engine: Lure
Note: See TracTickets for help on using tickets.