Opened 9 years ago

Closed 9 years ago

Last modified 13 days ago

#5433 closed defect (fixed)

DRASCULA: Code analysis warnings

Reported by: Templier Owned by: sev-
Priority: normal Component: Engine: Drascula
Keywords: build Cc:
Game: Drascula

Description

Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\engines\drascula\resource.cpp(95): warning C6031: Return value ignored: 'sscanf'
d:\sources\scummvm\scummvm\engines\drascula\resource.cpp(101): warning C6031: Return value ignored: 'sscanf'
d:\sources\scummvm\scummvm\engines\drascula\rooms.cpp(1948): warning C6031: Return value ignored: 'sscanf'
d:\sources\scummvm\scummvm\engines\drascula\saveload.cpp(224): warning C6031: Return value ignored: 'sscanf'

Note:
If you want to try it yourself, you will need:
- the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b )
- the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

Ticket imported from: #3087830. Ticket imported from: bugs/5433.

Change History (4)

comment:1 by sev-, 9 years ago

Fixed, thanks

comment:2 by sev-, 9 years ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

comment:3 by digitall, 12 months ago

Component: Engine: Drascula

comment:4 by Thunderforge, 13 days ago

Game: Drascula
Note: See TracTickets for help on using tickets.