Opened 9 years ago

Closed 9 years ago

Last modified 11 months ago

#5432 closed defect (fixed)

CRUISE: Code analysis warnings

Reported by: Templier Owned by: sev-
Priority: normal Component: Engine: Cruise
Keywords: build Cc:
Game:

Description

Here are the warnings I get when compiling the engine using Code Analysis in VS2010. I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\engines\cruise\function.cpp(61): warning C6203: Buffer overrun for non-stack buffer 'char * Cruise::nextOverlay' in call to 'strcpy': length '38' exceeds buffer size '15'

d:\sources\scummvm\scummvm\engines\cruise\script.cpp(188): warning C6011: Dereferencing NULL pointer 'ptr+var_A+offset'

Note:
If you want to try it yourself, you will need:
- the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b )
- the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

Ticket imported from: #3087829. Ticket imported from: bugs/5432.

Change History (4)

comment:1 by Templier, 9 years ago

Summary: Cruise: Code analysis warningsCRUISE: Code analysis warnings

comment:2 by sev-, 9 years ago

Fixed.

comment:3 by sev-, 9 years ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

comment:4 by digitall, 11 months ago

Component: Engine: Cruise
Note: See TracTickets for help on using tickets.