Opened 9 years ago

Closed 8 years ago

Last modified 7 months ago

#5431 closed defect (fixed)

AGOS: Code analysis warnings

Reported by: Templier Owned by: bluegr
Priority: normal Component: Engine: AGOS
Keywords: build Cc:
Game:

Description (last modified by digitall)

Here are the warnings I get when compiling the AGOS engine using Code Analysis in VS2010.

I tried to remove all the obvious false positives. Some warnings look suspicious, others are pointing to correct code that still might benefit from better error checking.

d:\sources\scummvm\scummvm\engines\agos\script_pn.cpp(894): warning C6011: Dereferencing NULL pointer '_stackbase'
d:\sources\scummvm\scummvm\engines\agos\string.cpp(858): warning C6011: Dereferencing NULL pointer 'ptr' (looks like a false positive)
d:\sources\scummvm\scummvm\engines\agos\verb_pn.cpp(188): warning C6011: Dereferencing NULL pointer '_dragStore'

Note: If you want to try it yourself, you will need:
- the create_project patch set, along with the WIP code analysis patch (http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b )
- the following patch to silence some false positives ( http://bitbucket.org/Littleboy/scummvm-jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch )
- Visual Studio 2010 Ultimate or Team System (create_project support for analysis with VS2005/2008 isn't complete yet)

Ticket imported from: #3087828. Ticket imported from: bugs/5431.

Change History (7)

comment:1 Changed 9 years ago by bluegr

Owner: set to bluegr
Resolution: fixed
Status: newclosed

comment:2 Changed 9 years ago by bluegr

Fixed in rev #53503

comment:3 Changed 8 years ago by Templier

Status: closednew

comment:4 Changed 8 years ago by Templier

Here are the results of the last analysis build:

d:\sources\scummvm\scummvm-jt\engines\agos\string.cpp(522): warning C6336: Arithmetic operator has precedence over question operator, use parentheses to clarify intent

(it stills warns about the NULL dereference in string.cpp and verb_pn.cpp, but I'm guessing those have been checked as being false positives).

comment:5 Changed 8 years ago by Templier

Status: newclosed

comment:6 Changed 8 years ago by Templier

Results from the last run (around June 6 2011) are available here: https://gist.github.com/1008034

comment:7 Changed 7 months ago by digitall

Component: Engine: AGOS
Description: modified (diff)
Note: See TracTickets for help on using tickets.