Opened 17 years ago

Closed 17 years ago

Last modified 10 years ago

#537 closed defect (fixed)

DOTT: heavy "white" bug

Reported by: SF/andrej4000 Owned by: SF/ender
Priority: high Component: Engine: SCUMM
Keywords: Cc:
Game: Day of the Tentacle

Description

1) litlle bug: when in past the 3 guys jump out of the
windows, the animation of them is missing, you see
just their white silouetts.

2) havy bug: When in the future you dress Laverne,
the background bitmap in every room in the future
disappears, you just see the white...

I played the english DOTT Talkie with CVS from 5th
November.

Ticket imported from: #634424. Ticket imported from: bugs/537.

Attachments (2)

tentacle.s03 (53.1 KB ) - added by SF/andrej4000 17 years ago.
white backgound
dig-pal.gif (150.7 KB ) - added by SF/andrej4000 17 years ago.
Dig-Screenshot with solid white

Download all attachments as: .zip

Change History (11)

by SF/andrej4000, 17 years ago

Attachment: tentacle.s03 added

white backgound

comment:1 by SF/andrej4000, 17 years ago

Priority: normalhigh

comment:2 by eriktorbjorn, 17 years ago

This bug was introduced by a change to setPaletteFromPtr()
in revision 1.47 of gfx.cpp. The current version is clearly
wrong, because in the case of Laverne DOTT will set colours
16-191 and 207 to solid white (255 255 255), while the old
version leaves them unchanged.

What would make the most sense to me would be if 255 255 255
was the only colour that meant "leave this colour
unchanged", but I have no evidence whatsoever to confirm
this theory.

comment:3 by SF/ender, 17 years ago

No, the disassembly actually makes that exact (if r < 0xFC || g <
0xFC...) comparison. Oddly.

I've commited a fix for it, although you'll need to leave and
reenter the room for the savegame to correct itself.

comment:4 by SF/ender, 17 years ago

Owner: set to SF/ender
Resolution: fixed
Status: newclosed

by SF/andrej4000, 17 years ago

Attachment: dig-pal.gif added

Dig-Screenshot with solid white

comment:5 by SF/andrej4000, 17 years ago

Owner: SF/ender removed
Status: closednew

comment:6 by SF/andrej4000, 17 years ago

Newer games like DIG use really the solid white, so a check
for scumm version should be set.

comment:7 by SF/andrej4000, 17 years ago

Status: newclosed

comment:8 by SF/andrej4000, 17 years ago

Ender solved this problem, so I'll close this thread.

comment:9 by Kirben, 10 years ago

Owner: set to SF/ender
Note: See TracTickets for help on using tickets.