Opened 9 years ago

Closed 9 years ago

#5330 closed defect (fixed)

SCI: Notes not stopping correctly

Reported by: lordhoto Owned by: bluegr
Priority: normal Component: Engine: SCI
Keywords: Cc:
Game: King's Quest 6

Description

ScummVM trunk r52529
Linux/amd64 g++ 4.4.4

Happens with:
King's Quest 6 German Floppy "1.000" (according to VERSION file)
King's Quest 6 CD "1.000.00G" (according to VERSION file)
Both are from this KQ collection btw: http://wiki.scummvm.org/index.php/SCI/Game_Collections#King.27s_Quest_Collection

I am using "True Roland MT-32" and "Mixed AdLib/MIDI Mode" (happens without Mixed AdLib/MIDI Mode too though). This does *not* happen with AdLib.

When opening up the magical map to travel between the isles the sound effect is never stopped (or maybe it's just a note from the tune which is played?). That persists even after I quit ScummVM. So I guess the note off command is never sent. On my MT-32's display the number "4" is replaced by a block, so it should be a note on the MT-32.

I am attaching two save games, one for KQ6 Floppy and one for KQ6 CD. Just open the magical map and you will hear it.

Ticket imported from: #3059479. Ticket imported from: bugs/5330.

Attachments (3)

kq6ger.002 (43.9 KB ) - added by lordhoto 9 years ago.
KQ6 German floppy save
kq6cd.001 (39.7 KB ) - added by lordhoto 9 years ago.
KQ6 CD save
pepper_whistling.mp3 (94.0 KB ) - added by bluegr 9 years ago.
Pepper music "whistling" (hanging note) from bug #3035609

Download all attachments as: .zip

Change History (10)

by lordhoto, 9 years ago

Attachment: kq6ger.002 added

KQ6 German floppy save

by lordhoto, 9 years ago

Attachment: kq6cd.001 added

KQ6 CD save

comment:1 by lordhoto, 9 years ago

Summary: KQ6: Sound effect never stops (MT-32)KQ6: Sound effect never stops (MIDI)

comment:2 by lordhoto, 9 years ago

I tried again with my Audigy's wavetable synth (and without True Roland MT-32, thus General MIDI) and it seems it happens there too, but the note is much lower volume and it even seems like it lowers the volume a bit over time. After 5s you have to listen very closely (and might need to wait for the water sounds to be silent for a moment) to notice it.

comment:3 by bluegr, 9 years ago

Updated bug description, and merged duplicate bugs #3042573 and #3035609 into this one, as it appears to be a more generic SCI bug.

From bug #3042573 (using r51934): "SQ1EGA: In the Kerona Bar, when the band is playing, some channels are not muted when done, and their last note is still playing. This can carry on even after loading another saved game."

From bug #3035609 (using r51401 probably, since the timestamp is Jul 27 2010 23:14:01), the demo of Pepper is also affected by this, as there's a long leftover note playing at a low volume together with the song (recording taken from that bug report is attached here)

comment:4 by bluegr, 9 years ago

Summary: KQ6: Sound effect never stops (MIDI)SCI: Notes not stopping correctly

by bluegr, 9 years ago

Attachment: pepper_whistling.mp3 added

Pepper music "whistling" (hanging note) from bug #3035609

comment:5 by bluegr, 9 years ago

Merged duplicate bug #3102661. From that bug: "When you run into the grey horse, it plays a musical theme. When the horse trots off and disappears, the musical theme just hangs on one note, not stopping. This behavior happens when using the real MT-32 or the MT-32 emulator.

I'm using KQ4, version 1.000.111"

comment:6 by bluegr, 9 years ago

All these issues were fixed with rev #54429 (thanks to sven): when stopping a song and all of its notes, sustained notes would not stop because the stustain off signal wasn't sent. Now that it's sent, notes are stopping correctly.

Closing

comment:7 by bluegr, 9 years ago

Owner: set to bluegr
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.