#5256 closed defect (fixed)
SCI Fallback detector crashes with several games
| Reported by: | SF/ssburnout | Owned by: | bluegr |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCI |
| Version: | Keywords: | detection | |
| Cc: | Game: |
Description
rev 52133 compiled with MSVC 2010 for Win32.
Crashes with the following games which aren't in the detection tables yet:
Police Quest 3 DOS 1.0 EGA (6 x 3.5" disks) Conquests of the Longbow DOS 1.0 EGA (4 x 5.25" disks) Space Quest I 2.0 EGA DOS (6 x 3.5" disks) Leisure Suit Larry 5 1.0 EGA (8 x 3.5" disks)
Crashes on line 2065 in resource.cpp, it seems like a problem with the global variable g_sci
if ((g_sci->getGameId() == GID_LSL1) && (g_sci->getLanguage() == Common::ES_ESP)) {
Here is the call stack:
> scummvm.exe!Sci::ResourceManager::detectSciVersion() Line 2065 + 0xb bytes C++ scummvm.exe!Sci::ResourceManager::init() Line 839 C++ scummvm.exe!Sci::SciMetaEngine::fallbackDetect(const Common::FSList & fslist) Line 517 C++ scummvm.exe!AdvancedMetaEngine::detectGames(const Common::FSList & fslist) Line 223 + 0x13 bytes C++ scummvm.exe!EngineManager::detectGames(const Common::FSList & fslist) Line 410 + 0x30 bytes C++
> scummvm.exe!Sci::ResourceManager::detectSciVersion() Line 2065 + 0xb bytes C++ scummvm.exe!Sci::ResourceManager::init() Line 839 C++ scummvm.exe!Sci::SciMetaEngine::fallbackDetect(const Common::FSList & fslist) Line 517 C++ scummvm.exe!AdvancedMetaEngine::detectGames(const Common::FSList & fslist) Line 223 + 0x13 bytes C++ scummvm.exe!EngineManager::detectGames(const Common::FSList & fslist) Line 410 + 0x30 bytes C++ scummvm.exe!GUI::LauncherDialog::addGame() Line 738 C++ scummvm.exe!GUI::LauncherDialog::handleCommand(GUI::CommandSender * sender, unsigned int cmd, unsigned int data) Line 925 + 0xf bytes C++ scummvm.exe!GUI::CommandSender::sendCommand(unsigned int cmd, unsigned int data) Line 54 + 0x23 bytes C++ scummvm.exe!GUI::ButtonWidget::handleMouseUp(int x, int y, int button, int clickCount) Line 297 + 0x1c bytes C++ scummvm.exe!GUI::Dialog::handleMouseUp(int x, int y, int button, int clickCount) Line 202 + 0x63 bytes C++ scummvm.exe!GUI::GuiManager::runLoop() Line 353 + 0x2a bytes C++ scummvm.exe!GUI::Dialog::runModal() Line 80 C++ scummvm.exe!launcherDialog() Line 84 + 0xb bytes C++ scummvm.exe!scummvm_main(int argc, const char * const * argv) Line 390 C++ scummvm.exe!SDL_main(int argc, char * * argv) Line 66 + 0xd bytes C++ scummvm.exe!WinMain(HINSTANCE__ * __formal, HINSTANCE__ * __formal, HINSTANCE__ * __formal, HINSTANCE__ * __formal) Line 51 + 0x12 bytes C++ scummvm.exe!__tmainCRTStartup() Line 275 + 0x2c bytes C scummvm.exe!WinMainCRTStartup() Line 189 C
Ticket imported from: #3046800. Ticket imported from: bugs/5256.
Change History (4)
comment:1 by , 14 years ago
comment:3 by , 14 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:4 by , 5 years ago
| Component: | → Engine: SCI |
|---|
Oops, sorry for the duplicate call stack entries. By the way, my PQ3 EGA MD5s are exactly the same as the ones listed in the following bug report, which mention a (very likely) identical crash: https://sourceforge.net/tracker/?func=detail&aid=3046573&group_id=37116&atid=418820