Opened 17 years ago

Closed 17 years ago

Last modified 7 months ago

#52 closed defect (fixed)

Sam and Max: Inventory Hack (FIXME)

Reported by: SF/demon Owned by: SF/ender
Priority: low Component: Engine: SCUMM
Keywords: Cc:
Game: Sam and Max

Description

By changing the error() call for the stub of
o6_miscOps_108 to a warning(), the game continues.
However, when I have Sam and Max ride the "Cone
o'Tragedy", then take the claim ticket to the Lost &
Found, I never get my inventory back. I go walk in, and
the attendant tells Sam everything they've found today
is his - but clicking the inventory button brings up an
empty inventory. I don't see any stubbed functions
getting called in the program's stdout/stderr, so I can
only assume whatever routine it is that is supposed to
save (or restore?) the inventory is not saving (or
restoring?) it properly.

Ticket imported from: #493153. Ticket imported from: bugs/52.

Change History (12)

comment:1 Changed 17 years ago by SF/strigeus

Owner: set to SF/strigeus
Summary: Sam & Max: Missing inventorySam & Max: Missing inventory

comment:2 Changed 17 years ago by SF/ender

Still havn't figured this one out.

The inventory appears to be reassigned correctly... Grr.

comment:3 Changed 17 years ago by SF/ender

Owner: changed from SF/strigeus to SF/ender

comment:4 Changed 17 years ago by zeldin

I tried this and found out that the inventory in fact _is_
restored, it's just that you can't see it (or select any
objects from it). If you go to the Tunnel of Love for example,
you can ride it (if you didn't have the inventory, Sam would
complain that he didn't have a pass). After the Tunnel of
Love ride, I could see and use the inventory again.

I couldn't play past the restaurant on top of the twine ball
though, the game exited as soon as I walked into the restaurant.

comment:5 Changed 17 years ago by SF/ender

Yeah, thats what I saw too.

Actually, thinking about it... what's probably happening is
scummvm flushing the image data when it's moved between
rooms.

Hummm.

comment:6 Changed 17 years ago by SF/ender

I've just committed a nasty hack that works around an
apparantly script bug in script 207 (room 15) - it should
call script 52 (the 'add inventory item' script) for each
item just in the loop.

As a hack I've put a hack in 'setOwner' to basically do
this manually.

This part of Sam and Max now works. I'm leaving this bug
open however, as the real problem should probably be
located, instead of this workaround.

comment:7 Changed 17 years ago by (none)

Logged In: NO

Now I can come till the crocodile golf...
When I'm trying to enter the scene with the crocodiles
swimming, the game ends with "a probably BIG error"...

comment:8 Changed 17 years ago by SF/ender

Gator Golf should now be working fine...

comment:9 Changed 17 years ago by SF/ender

Priority: normallow
Summary: Sam & Max: Missing inventorySam and Max: Inventory Hack (FIXME)

comment:10 Changed 17 years ago by SF/ender

Closing this, as sam and max seems to work fine - even with
the hack. :)

comment:11 Changed 17 years ago by SF/ender

Resolution: fixed
Status: newclosed

comment:12 Changed 7 months ago by digitall

Component: Engine: SCUMM
Game: Sam and Max
Note: See TracTickets for help on using tickets.