#5078 closed defect (fixed)
KQ5: Music not fading when brigands leave temple
| Reported by: | SF/kurufinwe | Owned by: | sluicebox |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCI |
| Version: | Keywords: | ||
| Cc: | Game: | King's Quest 5 |
Description
When Graham spies on the brigands at the desert temple, the game crashes when they ride out of the screen.
Console output: parameter 0: 0001:04e2 (object), should be object parameter 1: 0020:08a6 (object), should be null, integer parameter 2: 0000:0006 (integer), should be null, integer parameter 3: 0000:000a (integer), should be null, integer parameter 4: 0001:04e2 (object), should be null, integer [VM] kDoSound(Fade): signature mismatch via method globalSound3::fade (script 989, room 213, localCall ffffffff)!
A save is attached (hide and wait for the brigands to show up).
Game version: Floppy, DOS, English ScummVM version: 1.2.0svn51527 under Mac OS X 10.6 (MacBook 5,2)
Ticket imported from: #3037594. Ticket imported from: bugs/5078.
Attachments (1)
Change History (21)
by , 14 years ago
comment:1 by , 14 years ago
should have been fixed with r51627
i can't test, because i don't own this version. Please test and reply if it worked.
comment:2 by , 14 years ago
| Status: | new → pending |
|---|
comment:3 by , 14 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
comment:4 by , 14 years ago
Unfortunately, that didn't work. With rev 51672, the game still crashes at the same point with the same error message.
comment:5 by , 14 years ago
| Resolution: | fixed |
|---|---|
| Status: | pending → new |
comment:7 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → pending |
comment:8 by , 14 years ago
| Status: | pending → new |
|---|
comment:9 by , 14 years ago
It doesn't crash anymore now, thanks.
The music is cut off very abruptly, whereas with the original interpreter it fades out nicely, but I guess that's not all that important. I'm leaving the bug pending, in case you want to reopen it and investigate that part.
Anyway, the desert is completable. Let's look at the forest now!
comment:11 by , 14 years ago
| Status: | new → closed |
|---|
comment:12 by , 14 years ago
| Status: | closed → new |
|---|
comment:16 by , 14 years ago
| Summary: | KQ5: Crash when brigands leave temple → KQ5: Music not fading when brigands leave temple |
|---|
comment:17 by , 13 years ago
| Owner: | removed |
|---|
comment:18 by , 13 years ago
Fixed in r9ad4ad1 It was caused because the song signal was incorrectly set when music fading completed (same as bug #3044844)
comment:19 by , 13 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:20 by , 21 months ago
| Owner: | changed from to |
|---|
*Arise ticket, arise!*
I've updated the workaround entry and removed the workaround code from kDoSoundFade; the music now fades correctly as in the original instead of stopping abruptly: https://github.com/scummvm/scummvm/commit/d2d46b67c5950cc74664ca584f338190bc4d59aa
Save