Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#4789 closed defect (fixed)

AGI: (Fan) SQ0: Text input field overdraws Text window

Reported by: raziel- Owned by: sev-
Priority: normal Component: Engine: AGI
Keywords: Cc:
Game: AGI Fanmade

Description

ScummVM 1.1.0svn48149 (Feb 27 2010 22:03:54)
Features compiled in: Vorbis FLAC MP3 RGB zLib

In some scenes (six overall) of that game the text input field on the bottom of the screen erases the bottom part of the displayed text windows.
I have gathered all occasions as there are only two scenes affected

Space Quest 0 - Replicated v1.04 (DOS/English)

AmigaOS4
gcc version 4.2.4 (adtools build 20090118)

Ticket imported from: #2960563. Ticket imported from: bugs/4789.

Attachments (8)

sq0.022 (4.8 KB ) - added by raziel- 10 years ago.
type "eavesdrop" to start the scene (issues 1 and 2)
AGI (Fan) SQ0 - Text input field overdraws text window_1.png (47.8 KB ) - added by raziel- 10 years ago.
Issue 1
AGI (Fan) SQ0 - Text input field overdraws text window_2.png (48.2 KB ) - added by raziel- 10 years ago.
Issue 2
sq0.041 (3.1 KB ) - added by raziel- 10 years ago.
Just walk left out the room and let the scene start
AGI (Fan) SQ0 - Text input field overdraws text window_3.png (22.9 KB ) - added by raziel- 10 years ago.
Issue 3
AGI (Fan) SQ0 - Text input field overdraws text window_4.png (21.0 KB ) - added by raziel- 10 years ago.
Issue 4
AGI (Fan) SQ0 - Text input field overdraws text window_5.png (18.8 KB ) - added by raziel- 10 years ago.
Issue 5
AGI (Fan) SQ0 - Text input field overdraws text window_6.png (18.9 KB ) - added by raziel- 10 years ago.
Issue 6

Download all attachments as: .zip

Change History (14)

by raziel-, 10 years ago

Attachment: sq0.022 added

type "eavesdrop" to start the scene (issues 1 and 2)

comment:1 by raziel-, 10 years ago

Summary: AGI: (Fan) SQ0: Text input field overdrawstText windowAGI: (Fan) SQ0: Text input field overdraws Text window

by raziel-, 10 years ago

Attachment: sq0.041 added

Just walk left out the room and let the scene start

comment:2 by SF/david-kaplan, 10 years ago

This occurs because cmd_prevent_input() is executed which calls g_agi->clearPrompt();

as the propt appears on the same line as the bottom of the blitted textbox, the text box is cut.

What is the behaviour of the original in this case?

comment:3 by raziel-, 10 years ago

This doesn't happen with NAGI, though NAGI display a far wider screen and
the text output fits in one line and not two like ScummVM does it.

Maybe this can be solved by fitting the output in one line by not
line-breaking too early?
otoh i don't really know what i'm talkign about ;-)

See bug #2960558, they are related if not duplicates

comment:4 by sev-, 9 years ago

Fixed in svn. Actually redrawing that in prevent.input is all correct, but our line breaking width computation was not. Now it matches NAGI.

comment:5 by sev-, 9 years ago

Resolution: fixed
Status: newclosed

comment:6 by sev-, 9 years ago

Owner: set to sev-
Note: See TracTickets for help on using tickets.