Opened 9 years ago

Closed 9 years ago

#4785 closed defect (fixed)

RTZ: crash when using original GUI to quit

Reported by: criezy Owned by: SF/mthreepwood
Priority: normal Component: Engine: MADE
Keywords: Cc:
Game: Return to Zork

Description

Using the original GUI to quit Return to Zork crashes ScummVM. It works when using the GMM to either return to the launcher or quit ScummVM, but since load and save (currently) only work through the original GUI, I would expect quitting the game to also work.

It crashes on line 496 of script.cpp (in engine/made/) because the Object pointer is NULL. I don't know what the function ScriptInterpreter::cmd_objectp() is supposed to do if the Object pointer is Null. I tried several things. Changing line 496 to

if (obj != NULL && obj->isObject())

fixes the crash but I get a stack overflow warning. Everything else I have tried causes a segmentation fault.

I am using ScummVM 1.1.0svn r48146 on MacOS X 10.4 Intel.

Ticket imported from: #2960238. Ticket imported from: bugs/4785.

Change History (3)

comment:1 Changed 9 years ago by criezy

I forgot to say I also get a lot of warnings about unknown opcodes when I quit using the original dialog:

WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 4C!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: Unimplemented command: cmd_split!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 4C!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: Unimplemented command: cmd_varx!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 4C!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode F2!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: Unimplemented command: cmd_vectorp!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 73!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 4C!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 4C!
WARNING: Unimplemented command: cmd_vectorp!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 76!
WARNING: Unimplemented command: cmd_vectorp!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 7B!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 4C!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode A6!
WARNING: Unimplemented command: cmd_vectorp!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode D0!
WARNING: Unimplemented command: cmd_vectorp!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 83!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 4C!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 8B!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 4C!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 5A!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 84!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 00!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode FF!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 7F!
WARNING: ScriptInterpreter::runScript(431) Unknown opcode 8A!

comment:2 Changed 9 years ago by SF/mthreepwood

Owner: set to SF/mthreepwood
Resolution: fixed
Status: newclosed

comment:3 Changed 9 years ago by SF/mthreepwood

Fixed in r48149.

Note: See TracTickets for help on using tickets.