Opened 10 years ago

Closed 10 years ago

Last modified 20 months ago

#4766 closed defect (fixed)

MP3 (CD Audio) Broken under SVN

Reported by: SF/mthreepwood Owned by: lordhoto
Priority: normal Component: Audio
Keywords: Cc:
Game: Loom

Description

Mac OS X 10.5 (x86), HEAD revision (r48028 at time of writing) Loom VGA CD, MP3 compressed audio

The audio does not play under the head revision right now. I dug a little into it, and I've tracked it to decodeMP3Data(). At the end of the function, there are these lines:

if (_stream.error != MAD_ERROR_NONE) _state = MP3_STATE_EOS;

At this point, _stream.error is MAD_ERROR_LOSTSYNC and therefore, since _state is now MP3_STATE_EOS, endOfData() will return true and then makeMP3Stream() will return 0. Commenting these two lines out makes sound work again. I'm not sure what is supposed to happen here or what change recently broke this.

Ticket imported from: #2948858. Ticket imported from: bugs/4766.

Change History (5)

comment:1 by lordhoto, 10 years ago

Can you try running ScummVM with -d6 or check whether you get any "MP3Stream: Unrecoverable error in mad_frame_decode" warning (or the like)?

comment:2 by lordhoto, 10 years ago

Owner: set to lordhoto

comment:3 by lordhoto, 10 years ago

Fixed with r48032 in trunk.

comment:4 by lordhoto, 10 years ago

Resolution: fixed
Status: newclosed

comment:5 by digitall, 20 months ago

Component: Audio
Game: Loom
Note: See TracTickets for help on using tickets.