Opened 13 years ago
Closed 13 years ago
Last modified 5 years ago
#4766 closed defect (fixed)
MP3 (CD Audio) Broken under SVN
|Reported by:||SF/mthreepwood||Owned by:||lordhoto|
Mac OS X 10.5 (x86), HEAD revision (r48028 at time of writing) Loom VGA CD, MP3 compressed audio
The audio does not play under the head revision right now. I dug a little into it, and I've tracked it to decodeMP3Data(). At the end of the function, there are these lines:
if (_stream.error != MAD_ERROR_NONE) _state = MP3_STATE_EOS;
At this point, _stream.error is MAD_ERROR_LOSTSYNC and therefore, since _state is now MP3_STATE_EOS, endOfData() will return true and then makeMP3Stream() will return 0. Commenting these two lines out makes sound work again. I'm not sure what is supposed to happen here or what change recently broke this.
Ticket imported from: #2948858. Ticket imported from: bugs/4766.
Change History (5)
comment:1 by , 13 years ago
comment:2 by , 13 years ago
comment:3 by , 13 years ago
Fixed with r48032 in trunk.
comment:4 by , 13 years ago
|Status:||new → closed|
comment:5 by , 5 years ago
Can you try running ScummVM with -d6 or check whether you get any "MP3Stream: Unrecoverable error in mad_frame_decode" warning (or the like)?