#471 closed defect (fixed)
ZAK256: No sound & music
| Reported by: | SF/trinity78 | Owned by: | Kirben |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Zak McKracken |
Description
Latest Build. One of the patches from today or yesterday killed all music (mp3) and sound in Zak256. Following error message: IMuseInternal::findTag completely failed finding Sound XX (93 in the first case)
My guess is on the sound patch for indy256 & monkey1.
Ticket imported from: #612632. Ticket imported from: bugs/471.
Change History (10)
comment:1 by , 22 years ago
comment:2 by , 22 years ago
| Owner: | set to |
|---|---|
| Summary: | Zak256: No sound & music → ZAK256: No sound & music |
comment:3 by , 22 years ago
Logged In: NO
hackish, but keeps indy256 and zak256 working:
/* FIXME */ if ((type == rtSound) && (_gameId != GID_ZAK256)) return readSoundResourceSmallHeader(type, idx);
and why don't you think so? :)
trin
comment:4 by , 22 years ago
| Owner: | changed from to |
|---|
comment:5 by , 22 years ago
Assigned to Kirben, as he checked in the original patch :-)
I accidentally assigned this at first to eriktobjorn, sorry for that.
comment:6 by , 22 years ago
Trin, I was wrong. I don't have ZAK256, so I could'nt test it myself. Which sound resource type is there used ? If it's not 'SO', than this may be much cleaner:
if ((type == rtSound) && (tag == 0x4F53)) // "SO" resource return readSoundResourceSmallHeader(type, idx);
Please look if it works for you.
comment:7 by , 22 years ago
mnepomuk, sorry to disappoint you but your change (tag == 0x4f53) doesn't work for Zak256.
Should this bug report closed?
comment:9 by , 22 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:10 by , 22 years ago
mnepomuk, yes it also uses SO. Refer to scumm/sound.cpp, around line 285, for details.
Also if you like you can come to IRC channel #scummvm, on irc.freenode.org (formerly openprojects), to discuss things like this in realtime if you like/can :-)
(I don't think so). Do commenting out the // if (type == rtSound) //return readSoundResourceSmallHeader(type, idx);