Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#470 closed defect (fixed)

MI1: new CDTimer breaks non CD games

Reported by: SF/mnepomuk Owned by: eriktorbjorn
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 1

Description

The invented _sound->readCDTimer() in scummvm.cpp stopps non CD-track MI1 games from showing ANY graphics (after restoring the deleted "if (delta) ..." clause it works again).

Ticket imported from: #612605. Ticket imported from: bugs/470.

Change History (10)

comment:1 by fingolfin, 18 years ago

Owner: set to eriktorbjorn

comment:2 by eriktorbjorn, 18 years ago

Just to clarify, you're talking about "monkey", not "monkeyvga", right?

comment:3 by eriktorbjorn, 18 years ago

Or maybe you did mean monkeyvga after all. I don't have it myself, and I got confused when Fingolfin said that the german version of monkeyvga works.

I've attached a new patch to patch #611997. It's basically what you suggest, but only for GID_MONKEY_VGA.

comment:4 by SF/freshman77, 18 years ago

ScummVM Win32 Snapshot of 23 Sep 2002 Monkey Island VGA (256 color Floppy version)

Just to confirm that this bug is still present in the 23 Sep Snapshot, i.e. after the copy protection, the turns black and stays like this. (The title music is played back but cannot be interrupted, and after it has finished nothing can be heard of seen at all. CTRL-ALT-F5 for opening the save/load menu doesn't work either.)

comment:5 by eriktorbjorn, 18 years ago

My patch has neither been accepted nor rejected yet so nothing has changed since yesterday, I'm afraid.

comment:6 by eriktorbjorn, 18 years ago

The patch has been applied to CVS. Please let me know if it works.

comment:7 by SF/freshman77, 18 years ago

Thanks for the update. I'll let you know as soon as the new Win32 snapshot is out.

comment:8 by SF/freshman77, 18 years ago

I've only just realised that the Win32 download does already link to the Sep 24 snapshot (in spite of what it says on the page). Result: The patch works and monkeyvga (Floppy version) runs smoothly again. :-)

comment:9 by eriktorbjorn, 18 years ago

Resolution: fixed
Status: newclosed

comment:10 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Monkey Island 1
Note: See TracTickets for help on using tickets.