Opened 17 years ago

Closed 16 years ago

#462 closed defect (fixed)

LOOMCD: Note letters vanish on save/load

Reported by: SF/dfabulich Owned by: Kirben
Priority: low Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

Play in standard mode, then save your game. The note
letters will disappear from the distaff (if you have
it). They will reappear if you have a conversation.
Load your game. The note letters will disappear again.

ScummVM 0.2.2 CVS
Built on Sep 15 2002 22:58:14

(downloaded Win32 snapshot)

Ticket imported from: #609723. Ticket imported from: bugs/462.

Change History (9)

comment:1 by SF/dfabulich, 17 years ago

Priority: normallow

comment:2 by eriktorbjorn, 17 years ago

From what I remember - I can't test at the moment - it's
enough just to bring up the save/load dialog. You don't
actually have to save or restore a game.

I think the problem is that ScummVM tries to do a full
redraw of the screen, but text messages (such as the note
letters) aren't redrawn.

comment:3 by fingolfin, 17 years ago

AFAIK that the distaff works at all in Loom is only thanks to a lot
hacking... so there are quite some issues open there.

comment:4 by SF/khalek, 17 years ago

yes the verbs (notes in this case) are manually offset to be
in the right position, but thats about the only hack I can
remember

comment:5 by fingolfin, 17 years ago

So, how are the note letter drawn exactly? Maybe we can fix it by correcting the _completeScreenRedraw code in scummvm.cpp (which is only used after a load took place.

comment:6 by eriktorbjorn, 17 years ago

As far as I can tell, it's script 18 that's responsible for
drawing the distaff, and it uses the print opcode to draw
the note names like this:

[00D1] (14)
print(254,[Pos(27,169),Color(Local[1]),Text("^16")]);

(The note names use character codes 16 through 23.)

So I guess the note names aren't really part of the verbs,
they're just drawn in the same area.

I haven't checked which script is responsible for drawing
the box of note names in practice mode, but I assume it's
handled in a similar fashion.

comment:7 by fingolfin, 16 years ago

Hm, I just thought about this... at least the original Loom, and also
Indy3 etc. had a script driven save/load dialog, I think... so if that was
really though (I am sure about Indy, but not Loom), then *maybe* that
took care of invoking script-18 (or whatever) to redraw the distaff...

If that is the case, we could implement a fix by checking after a load
whether this is Loom, then run a suitable script to cause the redraw of
the distaff.

But then it might be all different :-)

comment:8 by fingolfin, 16 years ago

Summary: LOOM: Note letters vanish on save/loadLOOMCD: Note letters vanish on save/load

comment:9 by Kirben, 16 years ago

Owner: set to Kirben
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.