Opened 15 years ago
Closed 3 years ago
#4575 closed defect (fixed)
SCUMM: FT - Issue with subtitles in French version
| Reported by: | SF/jlk661 | Owned by: | athrxx |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: | Full Throttle |
Description
There is an issue with subtitles before the final fight against Ripburger.
A screenshot is better than long (and boring) explanations, please see my file attachment.
Ticket imported from: #2846991. Ticket imported from: bugs/4575.
Attachments (6)
Change History (23)
by , 15 years ago
| Attachment: | 829369Full_Throttle__French__subtitle_bug.png added |
|---|
comment:3 by , 15 years ago
| Summary: | Full Throttle (French) CD (Ubuntu 8.04, SVN 43727) → FT: Issue with subtitles in French version |
|---|
comment:4 by , 13 years ago
JLK: There have been a number of corrections to Subtitle functions in SCUMM for FT. Please can you confirm if this is still occuring with the current stable release version i.e. v1.3.1 and if so, can you try a daily build from: http://www.scummvm.org/downloads/#daily And confirm if this is still present in current development master.
Thanks.
comment:5 by , 13 years ago
| Owner: | set to |
|---|
comment:6 by , 13 years ago
SylvainTV has this version and is going to try to replicate/confirm that this is fixed when he has time.
For reference, Boot Param 900 can be used to jump to the relevant section in ScummVM: http://wiki.scummvm.org/index.php/Boot_Params#Full_Throttle The same parameter can be used with the original interpreter for comparison using the debug mode: http://wiki.scummvm.org/index.php/SCUMM/Debug_Codes#Full_Throttle
comment:7 by , 13 years ago
SylvainTV reports that this is still occuring with latest Git master. From the attached screenshot, it looks like the subtitle newline symbol is not being recognised?
by , 13 years ago
| Attachment: | goodsubtitle.png added |
|---|
These are the good subtitles in the French version played in DOSbox
comment:9 by , 13 years ago
After further checks I noticed that the function to draw this text was :
void SmushFont::drawString(const char *str, byte *buffer, int dst_width, int dst_height, int x, int y, bool center)
There is no newline in str, and drawString does not cut the line.
comment:10 by , 13 years ago
There is a separate function (drawStringWrap) for wrapping the subtitles during smush scenes. The exact function to use, is selected by SmushPlayer::handleTextResource() in engines/scumm/smush/smush_player.cpp.
So check the bit values for flags in SmushPlayer::handleTextResource() during this scene, to see if there are any unexpected cases.
comment:11 by , 13 years ago
In SmushPlayer::handleTextResource() in engines/scumm/smush/smush_player.cpp.
// bit 0 - center 1 // bit 1 - not used 2 // bit 2 - ??? 4 // bit 3 - wrap around 8
The flag for both badly-displayed texts is "5". So it's treated as "1" without wrapping.
comment:12 by , 12 years ago
In the English version, this flag field is 13 i.e. 1101 binary which is masked off by 9 i.e. 1001 binary.. Looks like the unknown field in this is a duplicate wrap around flag. Attaching proposed patch to implement this.
by , 12 years ago
| Attachment: | 20120625-scumm-smush-flag.patch added |
|---|
Proposed Patch to deal with duplicate wraparound flag
comment:13 by , 12 years ago
Ah, after discussion with SylvainTV and some checking, this understanding is not correct either. Attaching a new proposed patch to fix this, but we will need to check as it appears to cause some regressions in FT French... despite correcting this fault.
by , 12 years ago
| Attachment: | 20120625-scumm-smush-flag-2.patch added |
|---|
Proposed Patch to correct SMUSH Text Flags meanings
comment:14 by , 4 years ago
| Summary: | FT: Issue with subtitles in French version → SCUMM: FT - Issue with subtitles in French version |
|---|
comment:15 by , 3 years ago
| Owner: | changed from to |
|---|---|
| Resolution: | → pending |
| Status: | new → pending |
Does it still happen?
The smush text display has been fixed mulitple times. It should be correct now.
comment:16 by , 3 years ago
This is now working properly, at least with the Macintosh French version.
by , 3 years ago
| Attachment: | ft-mac-fr-subtitle1.png added |
|---|
by , 3 years ago
| Attachment: | ft-mac-fr-subtitle2.png added |
|---|
comment:17 by , 3 years ago
| Resolution: | pending → fixed |
|---|---|
| Status: | pending → closed |
Thanks for the quick response. Confirmation for French FT is totally sufficient (I think I've done enough testing myself for English, Chinese and Korean DIG and COMI).
Screenshot of the wrong subtitle display