Opened 10 years ago

Last modified 7 years ago

#4575 new defect

FT: Issue with subtitles in French version

Reported by: SF/jlk661 Owned by: sylvaintv
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Full Throttle

Description

There is an issue with subtitles before the final fight against Ripburger.

A screenshot is better than long (and boring) explanations, please see my file attachment.

Ticket imported from: #2846991. Ticket imported from: bugs/4575.

Attachments (4)

829369Full_Throttle__French__subtitle_bug.png (80.5 KB ) - added by SF/jlk661 10 years ago.
Screenshot of the wrong subtitle display
goodsubtitle.png (52.4 KB ) - added by sylvaintv 8 years ago.
These are the good subtitles in the French version played in DOSbox
20120625-scumm-smush-flag.patch (1.4 KB ) - added by digitall 7 years ago.
Proposed Patch to deal with duplicate wraparound flag
20120625-scumm-smush-flag-2.patch (1.6 KB ) - added by digitall 7 years ago.
Proposed Patch to correct SMUSH Text Flags meanings

Download all attachments as: .zip

Change History (17)

by SF/jlk661, 10 years ago

Screenshot of the wrong subtitle display

comment:1 by sev-, 10 years ago

Could you also provide the savefile?

comment:2 by sev-, 10 years ago

For the record, Ubuntu, 1.1.0svn43727

comment:3 by sev-, 10 years ago

Summary: Full Throttle (French) CD (Ubuntu 8.04, SVN 43727)FT: Issue with subtitles in French version

comment:4 by digitall, 8 years ago

JLK: There have been a number of corrections to Subtitle functions in SCUMM for FT. Please can you confirm if this is still occuring with the current stable release version i.e. v1.3.1 and if so, can you try a daily build from:
http://www.scummvm.org/downloads/#daily
And confirm if this is still present in current development master.

Thanks.

comment:5 by digitall, 8 years ago

Owner: set to sylvaintv

comment:6 by digitall, 8 years ago

SylvainTV has this version and is going to try to replicate/confirm that this is fixed when he has time.

For reference, Boot Param 900 can be used to jump to the relevant section in ScummVM:
http://wiki.scummvm.org/index.php/Boot_Params#Full_Throttle
The same parameter can be used with the original interpreter for comparison using the debug mode:
http://wiki.scummvm.org/index.php/SCUMM/Debug_Codes#Full_Throttle

comment:7 by digitall, 8 years ago

SylvainTV reports that this is still occuring with latest Git master.
From the attached screenshot, it looks like the subtitle newline symbol is not being recognised?

by sylvaintv, 8 years ago

Attachment: goodsubtitle.png added

These are the good subtitles in the French version played in DOSbox

comment:8 by sylvaintv, 8 years ago

Added a picture with good subtitles in DosBox

comment:9 by sylvaintv, 8 years ago

After further checks I noticed that the function to draw this text was :

void SmushFont::drawString(const char *str, byte *buffer, int dst_width, int dst_height, int x, int y, bool center)

There is no newline in str, and drawString does not cut the line.

comment:10 by Kirben, 8 years ago

There is a separate function (drawStringWrap) for wrapping the subtitles during smush scenes. The exact function to use, is selected by SmushPlayer::handleTextResource() in engines/scumm/smush/smush_player.cpp.

So check the bit values for flags in SmushPlayer::handleTextResource() during this scene, to see if there are any unexpected cases.

comment:11 by sylvaintv, 8 years ago

In SmushPlayer::handleTextResource() in engines/scumm/smush/smush_player.cpp.

// bit 0 - center 1
// bit 1 - not used 2
// bit 2 - ??? 4
// bit 3 - wrap around 8

The flag for both badly-displayed texts is "5". So it's treated as "1" without wrapping.

comment:12 by digitall, 7 years ago

In the English version, this flag field is 13 i.e. 1101 binary which is masked off by 9 i.e. 1001 binary.. Looks like the unknown field in this is a duplicate wrap around flag. Attaching proposed patch to implement this.

by digitall, 7 years ago

Proposed Patch to deal with duplicate wraparound flag

comment:13 by digitall, 7 years ago

Ah, after discussion with SylvainTV and some checking, this understanding is not correct either. Attaching a new proposed patch to fix this, but we will need to check as it appears to cause some regressions in FT French... despite correcting this fault.

by digitall, 7 years ago

Proposed Patch to correct SMUSH Text Flags meanings

Note: See TracTickets for help on using tickets.