Opened 10 years ago

Closed 10 years ago

#4512 closed defect (fixed)

DW1: Castle guards saying HIGH STRING at start of act 2

Reported by: SF/wooshell Owned by: dreammaster
Priority: normal Component: Engine: Tinsel
Keywords: script Cc:
Game: Discworld

Description

I just started Act 2 of DW1 (english) on yesterday's daily Windows build, and the castle guards keep saying !! HIGH STRING !! when cloud-talking to them. Looks like a script/string table bug to me. Savegame attached.

Ticket imported from: #2831159. Ticket imported from: bugs/4512.

Attachments (1)

dw.002 (2.7 KB ) - added by SF/wooshell 10 years ago.
savegame with broken castle guards

Download all attachments as: .zip

Change History (10)

by SF/wooshell, 10 years ago

Attachment: dw.002 added

savegame with broken castle guards

comment:1 by dreammaster, 10 years ago

I'm not able to replicate the error you described. First of all, I'm going to presume you have the GRA file version of the game, since that's the version the savegame loads for me in.

The 'HIGH STRING' message you describe is displayed if a 'message Id' is referred to that isn't present in the given language '.txt' file. Whilst there have been a few places where an invalid string Id has been requested because of script bugs, another possibility, and most likely in your case, is that your .txt file may be corrupt. I did a quick md5 sum of my english.txt file:

1cda31864620af353974a18203c55393 *english.txt

Could you verify that yours in the same? Given that the strings display correctly for me, and it's unlikely that there are multiple versions of the GRA version of the game, this is the most likely reason.

comment:2 by dreammaster, 10 years ago

Owner: set to dreammaster

comment:3 by fingolfin, 10 years ago

Summary: Castle guards saying HIGH STRING at start of act 2DW1: Castle guards saying HIGH STRING at start of act 2

comment:4 by dreammaster, 10 years ago

Status: newpending

comment:5 by dreammaster, 10 years ago

This tracker item is pending response by the submitter; we
cannot continue processing it before that happens. As a
consequence, its status has been set to "Pending". It will
automatically revert to "Open" once a new comment is made to
this item. If no response is made within 14 days, it will
automatically be closed.

Thank you.

comment:6 by SF/wooshell, 10 years ago

nope, md5sums are identical.
Z:\scummgames\discworld1eng>md5sum english.txt
1cda31864620af353974a18203c55393 *english.txt
and yes, it's the horribly bug-ridden GRA version.
no voice either when the high strings are to be said..

Rincewind: "So which one of you has the ugly wife?"
Guard left: !!HIGH STRING!!
Guard right: !!HIGH STRING!!
Rincewind: "Really?"
Guard left: !!HIGH STRING!!
Rincewind: "So are you gonna let me in?"
Guard right: "NO!"

comment:7 by SF/wooshell, 10 years ago

Status: pendingnew

comment:8 by dreammaster, 10 years ago

I finally replicated the problem. DW1 didn't have any opcode for passing control from one object to another, so all the various action scripts for the guards were replicated on both guards. But on the guard on the left, for some reason, had the incorrect message Ids you were experiencing. And for my original testing I had been double-clicking on the right guard.

I've committed a script fix for the problem.

comment:9 by dreammaster, 10 years ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.