Opened 10 years ago

Closed 10 years ago

Last modified 9 months ago

#4429 closed defect (fixed)

GUI: strange behaviour when closing window in debugger

Reported by: wjp Owned by: wjp
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

If the debugger console is open, and I press the 'close' button on the ScummVM window, strange things happen in some engines.

In SCUMM, AGI, AGOS and Tinsel, ScummVM quits as expected.
In Sky, the dialog remains visible, the mouse cursor turns black, and 2 seconds later ScummVM quits.
In SCI, the dialog remains visible, but things continue as usual. Doing this too often causes a DialogStack overflow.

Ticket imported from: #2823731. Ticket imported from: bugs/4429.

Change History (7)

comment:1 Changed 10 years ago by eriktorbjorn

The Beneath a Sky thing is probably because the game displays a farewell message for a little while before quitting. (I don't know about SCI, I haven't even enabled it yet in my local build.)

comment:2 Changed 10 years ago by eriktorbjorn

I think the problem with SCI is that it doesn't notice the "quit" event, since it's caught by the console window, not the SCI engine. Rather than capturing the event, it should probably call the Engine::shouldQuit() function. I'm just not sure where and how.

comment:3 Changed 10 years ago by eriktorbjorn

I see you added a call to shouldQuit(). Did it help with this bug?

comment:4 Changed 10 years ago by wjp

Yes, it did, thanks.

The behaviour in BASS is still somewhat confusing, but probably not worth adding workarounds for.

comment:5 Changed 10 years ago by wjp

Resolution: fixed
Status: newclosed

comment:6 Changed 10 years ago by eriktorbjorn

Owner: set to wjp

comment:7 Changed 9 months ago by digitall

Component: GUI
Note: See TracTickets for help on using tickets.