Opened 11 years ago

Closed 11 years ago

Last modified 2 years ago

#4402 closed defect (fixed)

BUILD: MacOS X nightly build version number wrong

Reported by: criezy Owned by: dhewg
Priority: normal Component: Port: Mac OS X
Keywords: Cc:
Game:

Description

The nightly build for MacOS X has the wrong version number (0.14.0svn, which is the version in the Info.plist file). The window title is correct however (it displays 1.0.0snv).

Ticket imported from: #2820503. Ticket imported from: bugs/4402.

Change History (6)

comment:1 by fingolfin, 11 years ago

The Info.plist file is created from an Info.plist.in file. Now the only dependency of Info.plist is Info.plist.in. Hence when the version or revision changes, that file is not recreated...

I guess similar issues affect other files that are created from ".in" files. Maybe we should simply delete (and hence recreate) these files whenever we start an incremental build. Or maybe once in a while, a "make clean" should be run. Or maybe before *every* build we should run "make clean" (thanks to ccache this shouldn't have a *too* negative impact...)

Andre, BTW, to how big did you set ccache's cache size? If it is too small to keep object files for all ports, it will become ineffective (and might in fact slow down builds).

comment:2 by fingolfin, 11 years ago

Owner: set to dhewg
Summary: MacOS X nightly build version number wrongBUILD: MacOS X nightly build version number wrong

comment:3 by dhewg, 11 years ago

Proposed solutions: 1) make the $(VERSION_FILES) rules in Makefile.common phony 2) remove the $(VERSION_FILES) stuff from the Makefiles altogether and add the osx and iphone Info.plist filenames to tools/update_version.pl

1) would gegenerate the target files as they are needed 2) would merge 2 ways of changing the version, but requires that the target files are checked in

I would go with 2), since merging 2 ways of doing the same thing is always a good thing imho :)

about ccache 2GB for the "buildbot" user, thats one cache for all ports. ccache -s: cache directory /var/lib/buildbot/.ccache cache hit 283271 cache miss 1982685 called for link 35270 compile failed 5222 preprocessor error 54 not a C/C++ file 69 no input file 1624 files in cache 52048 cache size 1021.8 Mbytes max cache size 2.0 Gbytes

comment:4 by dhewg, 11 years ago

Fixed in r43101 with solution 2) as stated in the previous comment

comment:5 by dhewg, 11 years ago

Resolution: fixed
Status: newclosed

comment:6 by digitall, 2 years ago

Component: Port: Mac OS X
Note: See TracTickets for help on using tickets.