Opened 10 years ago

Closed 10 years ago

#4395 closed defect (wontfix)

DW1: Wrong voice dialog

Reported by: SF/neosmagus Owned by: dreammaster
Priority: normal Component: Engine: Tinsel
Keywords: Cc:
Game: Discworld

Description

Version: ScummVM 1.0.0svn42377 (Jul 11 2009 18:38:41)
Discworld English talkie, copied from the cd to harddisk. I'm not sure which version it is though.

In the dining room when I spoke to the Lecturer in Recent Runes, he had an option to talk about the librarian, and after a couple lines Rincewind says "But its the same thing!" and the Lecturer in Recent Runes is supposed to respond with "No no no". However while the subtitle is correct, the sound clip that plays is Rincewind saying "Did you get the number of that Donkey Cart?"

Ticket imported from: #2820172. Ticket imported from: bugs/4395.

Attachments (1)

dw.001 (1.6 KB) - added by SF/neosmagus 10 years ago.
save game

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by SF/neosmagus

Attachment: dw.001 added

save game

comment:1 Changed 10 years ago by dreammaster

This is a script bug in the SCN version of Discworld 1, so should probably be added to the list in the Wiki

comment:2 Changed 10 years ago by sev-

But can we patch the script on the fly?

comment:3 Changed 10 years ago by sev-

Summary: Wrong voice dialogDW1: Wrong voice dialog

comment:4 Changed 10 years ago by dreammaster

I looked into this a bit further. It turns out it's not really a script bug, but rather bad sample data in the voice/samples file.

Somewhat surprisingly, each piece of text in the game has it's own unique sample - the offset array is loaded in SoundManager::openSampleFiles. So there are, for example, as many copies of the 'Donkey cart' sample in the sample file as there are references to it.

What this means is that in the SCN version, they seem to have accidentally physically replaced the 'No no no' sample in the sample file with a copy of the donkey cart sample - I compared the two versions, and accounting for an offset difference between the two files, the same sample 'position' was being played, it's that the data is different now.

So there's no way we could fix this without taking the raw sample data for that voice entry from the GRA and patching the SCN version with it. Theoretically possible if the games are ever freewared, but not right now.

Should the status of this bug be changed? Perhaps to Closed/Won't Fix or Closed/Postphoned?

comment:5 Changed 10 years ago by SF/neosmagus

I noticed the same thing happened a little later in the game with a misplaced voice sample. But I forgot to note it down at the time and then I couldn't remember which dialog it was. It was in Act 3 or Act 4.

So the mismatch is at least twice. It would be awesome if this was fixed in the freeware release :)

comment:6 Changed 10 years ago by fingolfin

Owner: set to dreammaster
Resolution: wontfix
Status: newclosed

comment:7 Changed 10 years ago by fingolfin

Nothing we can do about this then.

If there ever is a freeware release, we could look into patching this properly, though.

Note: See TracTickets for help on using tickets.