#4237 closed defect (fixed)
AMIGAOS: Makefile.common broken
| Reported by: | raziel- | Owned by: | waltervn |
|---|---|---|---|
| Priority: | normal | Component: | Port: AmigaOS4 |
| Version: | Keywords: | build | |
| Cc: | Game: |
Description
I get a Makefile.common:158:*** target pattern contains no `%'. Stop. on the latest revision
Must have been revision 39493 or 39494 which broke it?
Ticket imported from: #2691034. Ticket imported from: bugs/4237.
Change History (15)
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Yes, truly sorry, i mixed them, it was 39497 which broke it http://scummvm.svn.sourceforge.net/viewvc/scummvm/scummvm/trunk/Makefile.common?revision=39497 whereas 39496 runs fine http://scummvm.svn.sourceforge.net/viewvc/scummvm/scummvm/trunk/Makefile.common?revision=39496
comment:3 by , 16 years ago
Some preliminary conclusions after an IRC debugging session:
The direct reason it fails is that VERSION contains a grep error message rather than a version. The grep command executed is 'grep SCUMMVM_VERSION ${srcdir}/base/internal_version.h' with srcdir equal to '.' . Unfortunately '.' is not a valid path in AmigaOS, so grep can't open ./base/internal_version.h.
comment:4 by , 16 years ago
Now I am confused. Before rev 39497, that line of code used cat. Then rev 39497 changed it to use tail. And only the revision *after* that, 39528, changed it to use grep.
So... maybe it was broken long before 39497, and it just wasn't immediately obvious that VERSION and all derived values contained bogus data?
comment:5 by , 16 years ago
| Owner: | set to |
|---|
comment:6 by , 16 years ago
Possibly, yes
I can't check because in the meantime i updated my SDK (lots of bugfixes and additions) and maybe that was one of the reasons? Maybe a bugfix in my SDK brought it to show up?
I cross checked by building the past revisions and it definitely was introduced with 39497, 39496 doesn't have the error, but unfortunately none of the later ones fix it either :-/
comment:7 by , 16 years ago
Fixed in trunk. Worked around the grep issue by using cat to read internal_version.h and piping the output to grep.
comment:8 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:9 by , 16 years ago
Well, my confusion is not cleared: Does Walter's change really *fix* the issue, or just hide it again? If "grep" doesn't accept "." in a path, does cat?
Raziel, if you go into the ScummVM source dir and enter the following two commands, what do they output? grep SCUMMVM_VERSION ./base/internal_version.h
cat ./base/internal_version.h | grep SCUMMVM_VERSION
comment:10 by , 16 years ago
| Owner: | removed |
|---|---|
| Status: | closed → new |
comment:11 by , 16 years ago
/Development/Coding/Sources/scummvm> grep SCUMMVM_VERSION ./base/internal_version.h SDK:Local/C/grep: ./base/internal_version.h: No such file or directory
/Development/Coding/Sources/scummvm> cat ./base/internal_version.h | grep SCUMMVM_VERSION #define SCUMMVM_VERSION "0.14.0svn" SCUMMVM_SVN_REVISION
comment:12 by , 16 years ago
| Owner: | set to |
|---|
comment:14 by , 16 years ago
| Status: | new → closed |
|---|
comment:15 by , 6 years ago
| Component: | → Port: AmigaOS4 |
|---|
None of these revisions modified Makefile.common, or anything related to the build system. See here for all revisions that modified this file: <http://scummvm.svn.sourceforge.net/viewvc/scummvm/scummvm/trunk/Makefile.common?view=log>