Opened 12 years ago

Closed 12 years ago

#4184 closed defect (fixed)

NIPPON: Amiga demo quits before end credits

Reported by: Kirben Owned by: peres
Priority: normal Component: Engine: Parallaction
Keywords: Cc:
Game: Nippon Safes

Description

ScummVM 0.14.0svn (Feb 20 2009 20:43:40) Compiled under mingw with GCC 4.2.1-dw2 Running on Windows XP Media Center 2005 Edition Amiga demo of Nippon Safes

The Amiga demo of Nippon Safes currently quits, as soon as 'Nippon Safes Inc.' is completely displayed, and before the actual end credits start.

Ticket imported from: #2619824. Ticket imported from: bugs/4184.

Change History (7)

comment:1 by peres, 12 years ago

This is something I overlooked when I changed the main game loop to be non-blocking. Thus, the QUIT command is now executed after the credits display action is queued for execution, instead of after the credits have been shown.

I verified the scripts for other possible issues, and I found there is another spot where the QUIT command is used, that is at the very end of the full game version.

Note to myself: the right thing to do is to set the suspend flag of the command execution context from Parallaction_XX::callFunction.

comment:2 by Kirben, 12 years ago

If it effects the ending of the full game, doesn't that make it a critical issue? for ScummVM 0.13.0 release I mean.

comment:3 by Kirben, 12 years ago

Priority: normalblocker

comment:4 by peres, 12 years ago

Status: newpending

comment:5 by peres, 12 years ago

This bug should have been fixed in r38662 (r38663 for branch).

The full game is not affected, because the routine that is executed in that case (_c_endComment) blocks the main loop. I added a comment to that routine as well, in case some work is done on it later.

Please confirm and close the issue if the bug is squashed. Thanks :)

comment:6 by Kirben, 12 years ago

Priority: blockernormal
Resolution: fixed
Status: pendingclosed

comment:7 by Kirben, 12 years ago

Yes, definitely fixed now.

Note: See TracTickets for help on using tickets.