Opened 11 years ago

Closed 8 years ago

Last modified 11 months ago

#4153 closed defect (fixed)

VKEYBD: Invalid XML in vkeybd.xml / XML parser too limited

Reported by: fingolfin Owned by: fingolfin
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

In current SVN, the vkeybd.xml file (in backends/vkeybd/vkeybd.zip) contains invalid XML. Specifically, it contains attributes like these:
target="&"
target="<"

Neither is allowed, see <http://www.w3.org/TR/2004/REC-xml-20040204/#syntax>. Correct would be:
target="&amp;"
target="&lt;"
but our "XML" parser doesn't support these (mandatory to support for a true XML parser, which ours of course is not) entities.

Possible fixes:
* Fix the XML file then add support for the mandatory XML entities: &amp; &lt; &gt; &apos; &quot;
* switch to a non-XML file (the image map data could still be generated from a HTML imagemap as source, using a simple perl/python/whatever script).

Ticket imported from: #2596330. Ticket imported from: bugs/4153.

Change History (5)

comment:1 by Templier, 8 years ago

Owner: set to fingolfin

comment:2 by Templier, 8 years ago

Is this still relevant? It seems to have been fixed with f788920af97b44c9b715.

See https://github.com/scummvm/scummvm/commit/f788920af97b44c9b7158134ee5192045ab9ee42

comment:3 by fingolfin, 8 years ago

I guess it has been fixed for the time being. Fact remains that we ship an "XML parser" that is not actually parsing XML but rather something that is *similar* to (a subset of) XML. I am not quite happy about that, but it's another problem, so no reason to keep this bug open.

comment:4 by fingolfin, 8 years ago

Resolution: fixed
Status: newclosed

comment:5 by digitall, 11 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.